Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

Add eslint integration #2

Open
miketaylr opened this issue Aug 15, 2017 · 2 comments
Open

Add eslint integration #2

miketaylr opened this issue Aug 15, 2017 · 2 comments

Comments

@miketaylr
Copy link
Member

It would be nice if we used the same ruleset for this tool that we use for webcompat.com (minus globals):

https://github.com/webcompat/webcompat.com/blob/master/.eslintrc

@zoepage
Copy link
Member

zoepage commented Aug 15, 2017

Agreed. Will happen before publishing.

ToDo's

  • add ESLint
  • add Travis Ci integration
  • add tests (tap / tape)

(This can happen in parallel while webcompat/webcompat.com#1310 (comment))

zoepage added a commit that referenced this issue Aug 17, 2017
@zoepage
Copy link
Member

zoepage commented Aug 17, 2017

Eslint works perfectly. Two files got excluded on purpose, as they hold mostly special chars and no code logic.
👉 https://github.com/webcompat/webcompat-cli-tool/blob/master/lib/messages.js
👉 https://github.com/webcompat/webcompat-cli-tool/blob/master/lib/schema.js

Run npm run lint to run the linter.

Travis integration as well as the test will follow after we've done the refactor in webcompat/webcompat.com#1310 (comment)

@zoepage zoepage added this to the 2nd version of the tool milestone Aug 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants