Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

No exit when you change your mind #8

Open
karlcow opened this issue Aug 23, 2017 · 3 comments
Open

No exit when you change your mind #8

karlcow opened this issue Aug 23, 2017 · 3 comments

Comments

@karlcow
Copy link
Member

karlcow commented Aug 23, 2017

Let's say that the person started typing a number and wants to say "back off, you creep" (because the program is asking too much credentials). It's currently impossible. At least at step 2.

capture d ecran 2017-08-24 a 07 18 11

And the message says it's an error. I'm not sure it's just that I don't want to give any credentials.

Why is it important?

  • We need to let the person decides to exit. (we can explain the consequences)
  • We should let people be able to configure their project without credentials. (imagine you just want to modify a README or 4 characters in first-bugs in python). The first step becomes very high.
@miketaylr
Copy link
Member

Does ctrl+c not work?

@karlcow
Copy link
Member Author

karlcow commented Aug 24, 2017

Ctrl+c does work. What I meant is that the message instead of the current thing should be:

You didn't enter any valid GitHub client ID.
Do you want to stop? (Enter q)
Or do you want to try again? (paste your GitHub Client ID)

The Enter q could be Ctrl+c. but the q is more graceful. You can even leave a message saying: "Your configuration is not finalized. The project will work but it will not fetch issues."

Hope it helps.

@zoepage
Copy link
Member

zoepage commented Aug 25, 2017

I could add a catch for exit or something? So it would work for all steps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants