Fix: Re-enable no-broken-links and ignore rel=nofollow #5994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable the `no-broken-links` hint in the web-recommended configuration. Update the hint logic to ignore `<a>` elements that contain `rel="nofollow"` when checking for broken links (404, 410, 500, 503 status codes). This prevents reports for links explicitly marked as not endorsed. Add unit tests to verify that links with `rel="nofollow"` are correctly skipped, while ensuring that regular broken links are still reported as expected. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix webhintio#5754
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5754
Re-enable the
no-broken-linkshint in the web-recommended configuration. Update the hint logic to ignore<a>elements that containrel="nofollow"when checking for broken links (404, 410, 500, 503 status codes). This prevents reports for links explicitly marked as not endorsed.Add unit tests to verify that links with
rel="nofollow"are correctly skipped, while ensuring that regular broken links are still reported as expected.Pull request checklist
Make sure you: