Re-order taps after tap function is called to guarantee old taps are in correct order

[soc221b]

Suppose we have two plugins to be tapped:

The following example is WRONG. Please see this comment

hook.tap({
  name: 'a',
  before: 'b'
}, () => {})

hook.tap({
  name: 'b',
}, () => {})

Actual: taps are [{ name: 'b', ... }, { name: 'a', ... }].
Expected: taps should be [{ name: 'a', ...}, { name: 'b', ... }].

[alexander-akait]

You need tap b before tapping a

[sokra]

hook.tap({
  name: 'a',
  before: 'b'
}, () => {
    console.log("a");
})

hook.tap({
  name: 'b',
}, () => {
    console.log("b");
})

hook.call();
a
b

Working as expected for me

[soc221b]

Take another example:

hook.tap({
  name: 'a',
  before: 'b',
}, () => {
  console.log('a')
})

hook.tap({
  name: 'b',
  before: 'c',
}, () => console.log('b'))

hook.tap('c', () => console.log('c'))

hook.call()

// b
// a
// c