Skip to content

.tap() before parameter do not respects existing befores #168

Open
@Rulexec

Description

@Rulexec

Hello. I have three plugins:

  • A depends on B
  • B depends on C
  • C

They tap some hook with same stage in the following order:

  • A, B, C

Then inside

_insert(item) {
they got position incorrectly as:

  • B, A, C

It happens because current logic looks like:

  • Adding A, no taps, just add
  • Adding B, B has before, so if (before.size > 0) allows to skip A and be inserted in the start of taps (e.g. order now is B, A)
  • Adding C to the top, since it has no before rules

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions