Compile fail for m125

[M4ndro]

I use ubuntu:20.04, this is my compile steps:

mkdir libwebrtc_build
cd libwebrtc_build

touch .gclient
nano .gclient

solutions = [
{
"name" : 'src',
"url" : 'https://github.com/webrtc-sdk/webrtc.git@m125_release',
"deps_file" : 'DEPS',
"managed" : False,
"custom_deps" : {
},
"custom_vars": {},
},
]
target_os = ['linux']

gclient sync

cd /src
git clone https://github.com/webrtc-sdk/libwebrtc

nano BUILD.gn

deps = [ ":webrtc" ] => deps = [ ":webrtc" , "//libwebrtc" ]

export ARCH=x64

gn gen out/x64_release --args="target_os="linux" target_cpu="$ARCH" is_debug=false rtc_include_tests=false rtc_use_h264=true ffmpeg_branding="Chrome" is_component_build=false use_rtti=true use_custom_libcxx=false rtc_enable_protobuf=false"

ninja -C out/Linux-x64 libwebrtc

And it occurs:

ninja: Entering directory `out/Linux-x64'
[21/3093] CXX obj/modules/congestion_controller/goog_cc/loss_based_bwe_v2/loss_based_bwe_v2.o
FAILED: obj/modules/congestion_controller/goog_cc/loss_based_bwe_v2/loss_based_bwe_v2.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/modules/congestion_controller/goog_cc/loss_based_bwe_v2/loss_based_bwe_v2.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=LIBCPP_HARDENING_MODE_NONE -D_GLIBCXX_ASSERTIONS=1 -DCR_CLANG_REVISION="llvmorg-19-init-8091-gab037c4f-1" -DCR_SYSROOT_KEY=20230611T210420Z-2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_ENABLE_PROTOBUF=0 -DWEBRTC_STRICT_FIELD_TRIALS=0 -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE -DRTC_ENABLE_VP9 -DRTC_DAV1D_IN_INTERNAL_DECODER_FACTORY -DWEBRTC_HAVE_SCTP -DWEBRTC_USE_H264 -DWEBRTC_ENABLE_LIBEVENT -DWEBRTC_LIBRARY_IMPL -DWEBRTC_ENABLE_AVX2 -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -I../.. -Igen -I../../third_party/abseil-cpp -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -Werror -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -m64 -msse3 -Wno-builtin-macro-redefined -D__DATE_= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fno-math-errno -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wglobal-constructors -Wno-shadow -Wctad-maybe-unsupported -Wc++11-narrowing -Wundef -Wunused-lambda-capture -Wno-gcc-compat -Wno-unreachable-code-break -Wenum-compare-conditional -Wno-c++11-narrowing-const-reference -std=c++17 -Wno-trigraphs -gsimple-template-names -fno-exceptions --sysroot=../../build/linux/debian_bullseye_amd64-sysroot -fvisibility-inlines-hidden -Wnon-virtual-dtor -Woverloaded-virtual -c ../../modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc -o obj/modules/congestion_controller/goog_cc/loss_based_bwe_v2/loss_based_bwe_v2.o
../../modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc:552:10: error: no matching member function for call to 'emplace'
552 | config.emplace();
| ~~~~~~~^~~~~~~
../../build/linux/debian_bullseye_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/optional:848:2: note: candidate template ignored: requirement 'is_constructible_vwebrtc::LossBasedBweV2::Config' was not satisfied [with _Args = <>]
848 | emplace(_Args&&... __args)
| ^
../../build/linux/debian_bullseye_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/optional:858:2: note: candidate function template not viable: requires at least argument '__il', but no arguments were provided
858 | emplace(initializer_list<_Up> __il, _Args&&... __args)
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[42/3093] CXX obj/modules/desktop_capture/desktop_capture/egl_dmabuf.o
ninja: build stopped: subcommand failed.

[NebulaSleuth]

I am getting the same issue. @M4ndro did you find a solution?

[M4ndro]

@NebulaSleuth, no, I wasn't able to get it working. Instead, I changed to libdatachannel (https://github.com/paullouisageneau/libdatachannel)

[NebulaSleuth]

@M4ndro Thanks. I was able to get a build, but I had to use the 'origin/e2ee/key-ring-size' branch and the 'origin/m114_release' of webrtc-sdk. and then had to tweak a couple files (video_codec_interface.h & rtp_frame_reference_finder_fuzzer.cc) to get it to compile. not the best solution :(

[Serj1032]

I checked mainline webrtc and found next solution

diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
index 7deeb7ad64..f913557f8c 100644
--- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
+++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
@@ -545,11 +545,14 @@ absl::optional<LossBasedBweV2::Config> LossBasedBweV2::CreateConfig(
                     key_value_config->Lookup("WebRTC-Bwe-LossBasedBweV2"));
   }

-  absl::optional<Config> config;
+  // absl::optional<Config> config;
   if (!enabled.Get()) {
-    return config;
+    return std::nullopt;
   }
-  config.emplace();
+
+  Config _config;
+  Config* config = &_config;
+
   config->bandwidth_rampup_upper_bound_factor =
       bandwidth_rampup_upper_bound_factor.Get();
   config->bandwidth_rampup_upper_bound_factor_in_hold =
@@ -608,7 +611,7 @@ absl::optional<LossBasedBweV2::Config> LossBasedBweV2::CreateConfig(
   config->padding_duration = padding_duration.Get();
   config->bound_best_candidate = bound_best_candidate.Get();
   config->pace_at_loss_based_estimate = pace_at_loss_based_estimate.Get();
-  return config;
+  return _config;
 }

 bool LossBasedBweV2::IsConfigValid() const {

[weblucas]

I used the same solution for a ubuntu 22.04

I checked mainline webrtc and found next solution

diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
index 7deeb7ad64..f913557f8c 100644
--- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
+++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
@@ -545,11 +545,14 @@ absl::optionalLossBasedBweV2::Config LossBasedBweV2::CreateConfig(
key_value_config->Lookup("WebRTC-Bwe-LossBasedBweV2"));
}

• absl::optional config;

• // absl::optional config;
  if (!enabled.Get()) {

• return config;

• return std::nullopt;
  }

• config.emplace();

• Config _config;
• Config* config = &_config;
• config->bandwidth_rampup_upper_bound_factor =
  bandwidth_rampup_upper_bound_factor.Get();
  config->bandwidth_rampup_upper_bound_factor_in_hold =
  @@ -608,7 +611,7 @@ absl::optionalLossBasedBweV2::Config LossBasedBweV2::CreateConfig(
  config->padding_duration = padding_duration.Get();
  config->bound_best_candidate = bound_best_candidate.Get();
  config->pace_at_loss_based_estimate = pace_at_loss_based_estimate.Get();

• return config;

• return _config;
  }

bool LossBasedBweV2::IsConfigValid() const {