Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ice candidates missing on iOS 18 with multiple interfaces #148

Open
domindx opened this issue Sep 24, 2024 · 3 comments
Open

Ice candidates missing on iOS 18 with multiple interfaces #148

domindx opened this issue Sep 24, 2024 · 3 comments
Assignees
@hiroshihorie

Comments

@domindx
Copy link

domindx commented Sep 24, 2024

There was an issue in original WebRTC code that is already fixed.
https://webrtc-review.googlesource.com/c/src/+/359541

This currently breaks our application on iOS18 devices.
@hiroshihorie
Copy link
Member

Thanks for the report, @cloudwebrtc should we get this in ?

@davidliu
Copy link
Contributor

Yeah, looks like a pretty simple fix to patch in.

@hiroshihorie hiroshihorie mentioned this issue Oct 19, 2024
Merged
@hiroshihorie hiroshihorie self-assigned this Oct 19, 2024
hiroshihorie added a commit that referenced this issue Oct 19, 2024
@hiroshihorie
Fixed issue with missing network interfaces on iOS (#151)
cd6792e 
Related issue: #148
Cherry-pick :
https://webrtc.googlesource.com/src/+/fea60ef8e72fb17b4f8a5363aff7e63ab8027b4f

Fixed issue with network interfaces due to a missing return value in the
"nw_path_enumerate_interfaces(...)" block. Exposed in iOS 18,
RTCNetworkMonitor::initWithObserver will only enumerate the first
interface, instead of all device interfaces

Bug: webrtc:359245764
Change-Id: Ifb9f28c33306c0096476a4afb0cdb4d734e87b2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359541
Auto-Submit: Corby <[email protected]>
Commit-Queue: Jonas Oreland <[email protected]>
Reviewed-by: Kári Helgason <[email protected]>
Reviewed-by: Jonas Oreland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#42818}

Co-authored-by: Corby Hoback <[email protected]>
@klemenzagar91
Copy link

klemenzagar91 commented Oct 21, 2024 •
edited
Loading

Do we know when to expect this fix will be released?

@brookman brookman mentioned this issue Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiroshihorie hiroshihorie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidliu @hiroshihorie @klemenzagar91 @domindx