Skip to content

Minimise amount of skipped inspection tests with no upper-bound on GHC version. #520

@phadej

Description

@phadej

We have few tests (in fact just four!) predicated with no-upper bound GHC version, like ghcGE86failure.

% git grep 'ghc.*GE'
optics/tests/Optics/Tests/Core.hs:    ghcGE90failure $(inspectTest $ 'lhs09 === 'rhs09)
optics/tests/Optics/Tests/Core.hs:    ghcGE912failure $(inspectTest $ 'lhs11 === 'rhs11)
optics/tests/Optics/Tests/Core.hs:    ghc810andGE912failure $(inspectTest $ 'lhs16 === 'rhs16)
optics/tests/Optics/Tests/Eta.hs:    ghc82andGE90failure $(inspectTest $ 'eta6lhs === 'eta6rhs)

we should work towards either improving inspection-testing to make these equalities true, or on GHC to make them true (maybe both).


I have done some not too controversial work on inspection-testing helping with two cases. This is an issue to not forget to push that to the finish line.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions