Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fee Recipient is not coinbase #71

Closed
1 task done
sambacha opened this issue Apr 1, 2025 · 2 comments
Closed
1 task done

fee Recipient is not coinbase #71

sambacha opened this issue Apr 1, 2025 · 2 comments

Comments

@sambacha
Copy link

sambacha commented Apr 1, 2025

Check existing issues

Ox Version

~0.6

Current Behavior

fee Recipient is not coinbase. it's not part of the block body either per se.

https://github.com/wevm/ox/blame/6e1a02cde345b7e94ad34534e2b696aedeb163b4/src/core/BlockOverrides.ts#L13

![L13]((https://github.com/wevm/ox/blob/main/src/core/BlockOverrides.ts#L13)

Expected Behavior

https://github.com/ethereum/execution-apis/blob/40088597b8b4f48c45184da002e27ffc3c37641f/src/eth/block.yaml#L39

https://github.com/ethereum/execution-apis/blob/40088597b8b4f48c45184da002e27ffc3c37641f/src/schemas/block.yaml#L34

Steps To Reproduce

No response

Link to Minimal Reproducible Example

No response

Anything else?

No response

@jxom
Copy link
Member

jxom commented Apr 1, 2025

What is the issue? It is feeRecipient on BlockOverrides reference here: https://github.com/ethereum/execution-apis/blob/e56d3208789259d0b09fa68e9d8594aa4d73c725/src/schemas/execute.yaml#L117. The BlockOverrides schema was introduced with eth_simulateV1.

We have miner property on Block type already.

@jxom jxom closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2025
@sambacha
Copy link
Author

sambacha commented Apr 2, 2025

What is the issue? It is feeRecipient on BlockOverrides reference here: ethereum/execution-apis@e56d320/src/schemas/execute.yaml#L117. The BlockOverrides schema was introduced with eth_simulateV1.

We have miner property on Block type already.

I will open an issue then regarding https://github.com/ethereum/execution-apis/blob/e56d3208789259d0b09fa68e9d8594aa4d73c725/src/schemas/execute.yaml#L117 as this is incorrect. COINBASE is an EVM Opcode, FeeReciepent is an out of protocol definition provided by the validator to block builder. It can be the same but not necessarily so (its the same if validator builds the block).

updated: ethereum/execution-apis#644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants