Sign is unnecessarily async #1408
Unanswered
paulmillr
asked this question in
Idea / Feature Request
Replies: 2 comments 1 reply
-
Will add a note to change this to sync for v2. Background: it was originally async, and we didn’t want to break users (yet) so we left it async. |
Beta Was this translation helpful? Give feedback.
0 replies
-
this hasn't been fixed in v2 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This includes all methods that call
sign
- there are many of them. They could be sync, because underlying primitive is sync.This is breaking change.
https://github.com/wagmi-dev/viem/blob/d5eb4936438950714bef63c48b71d1d21358af60/src/accounts/utils/sign.ts#L20-L24
Beta Was this translation helpful? Give feedback.
All reactions