Fix: files in untracked directories are not shown in git add #459
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the value of git config status.showUntrackedFiles to the git status command we run in _forgit_add, defaulting to 'all' when unset. Additionally correctly handle directories in _forgit_add_preview for the case when status.showUntracked is explicitly set to 'normal'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
Thanks @carlfriedrich for your insights provided in #458 (comment). I've implemented this as suggested, including the preview for normal mode, for which I simply used our existing directory view:
Pass the value of
git config status.showUntrackedFilesto thegit statuscommand we run in_forgitladd, defaulting toallwhen unset.Additionally correctly handle directories in
forgit_add_previewfor the case whenstatus.showUntrackedis explicitly set tonormal.You can see the different modes in action here:
Type of change
Test environment
Fixes #458