🐛 In the view hierarchy, id is not unique, such as the items of listView.

Author: linjiang

pandora-core/src/main/java/tech/linjiang/pandora/inspector/treenode/TreeView.java

@@ -10,7 +10,6 @@
 import android.graphics.Rect;
 import android.graphics.RectF;
 import android.support.annotation.Nullable;
-import android.util.Log;
 import android.view.GestureDetector;
 import android.view.MotionEvent;
 import android.view.ScaleGestureDetector;
@@ -276,7 +275,6 @@ public boolean onFling(MotionEvent e1, MotionEvent e2, float velocityX, float ve
     };
 
     private void cancelAllAnim() {
-        Log.d(TAG, "cancelAllAnim: ");
         scroller.abortAnimation();
     }
 

pandora-core/src/main/java/tech/linjiang/pandora/ui/fragment/ViewAttrFragment.java

@@ -39,20 +39,13 @@ public class ViewAttrFragment extends BaseListFragment {
     @Override
     public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        int id = getArguments().getInt(PARAM1, View.NO_ID);
-        if (id == View.NO_ID) {
-            throw new IllegalArgumentException("nee provide a valid id");
-        }
         if (Pandora.get().getViewRoot() != null) {
-            targetView = Pandora.get().getViewRoot().findViewById(id);
+            targetView = findViewByDefaultTag(Pandora.get().getViewRoot());
             if (targetView == null) {
                 onBackPressed();
             } else {
-                if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN_MR1) {
-                    if (targetView.getId() == R.id.pd_view_default_id) {
-                        targetView.setId(View.NO_ID);
-                    }
-                }
+                // clear flag
+                targetView.setTag(R.id.pd_view_tag_for_unique, null);
             }
         } else {
             onBackPressed();
@@ -85,6 +78,22 @@ public void onItemClick(int position, BaseItem item) {
         loadData();
     }
 
+    private View findViewByDefaultTag(View root) {
+        if (root.getTag(R.id.pd_view_tag_for_unique) != null) {
+            return root;
+        }
+        if (root instanceof ViewGroup) {
+            ViewGroup parent = (ViewGroup) root;
+            for (int i = 0; i < parent.getChildCount(); i++) {
+                View view = findViewByDefaultTag(parent.getChildAt(i));
+                if (view != null) {
+                    return view;
+                }
+            }
+        }
+        return null;
+    }
+
     private void loadData() {
         showLoading();
         new SimpleTask<>(new SimpleTask.Callback<Void, List<BaseItem>>() {

pandora-core/src/main/java/tech/linjiang/pandora/ui/fragment/ViewFragment.java

@@ -69,17 +69,8 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
 
     @Override
     public void onClick(View v) {
-        int id = v.getId();
-        if (id == View.NO_ID) {
-            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
-                id = View.generateViewId();
-            } else {
-                id = R.id.pd_view_default_id;
-            }
-            v.setId(id);
-        }
-        Bundle bundle = new Bundle();
-        bundle.putInt(PARAM1, id);
-        launch(ViewAttrFragment.class, bundle);
+        // add flag
+        v.setTag(R.id.pd_view_tag_for_unique, new Object());
+        launch(ViewAttrFragment.class, null);
     }
 }

pandora-core/src/main/res/values/ids.xml

@@ -6,6 +6,6 @@
     <item name="pd_recycler_adapter_id" type="id"/>
     <!--toolbar-->
     <item name="pd_toolbar_id" type="id"/>
-    <!--The view needs to be specified when it is passed between fragments in case of NO_ID-->
-    <item name="pd_view_default_id" type="id"/>
+    <!--To identify the uniqueness of view temporarily when launching to other fragments-->
+    <item name="pd_view_tag_for_unique" type="id"/>
 </resources>