Skip to content

Commit 09811b4

Browse files
committed
Remove priority arguments from api
Remove the unused `*prorities` parameters to `api` calls. They are not used and add unnecessarily complexity. We are going to focus on config + package priorities instead.
1 parent 0890a15 commit 09811b4

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

variantlib/api.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import itertools
66
import logging
77
import pathlib
8-
from typing import TYPE_CHECKING
98

109
from variantlib.configuration import VariantConfiguration
1110
from variantlib.constants import VARIANT_HASH_LEN
@@ -25,11 +24,6 @@
2524
from variantlib.variant_dist_info import VariantDistInfo
2625
from variantlib.variants_json import VariantsJson
2726

28-
if TYPE_CHECKING:
29-
from variantlib.protocols import VariantFeatureName
30-
from variantlib.protocols import VariantFeatureValue
31-
from variantlib.protocols import VariantNamespace
32-
3327
logger = logging.getLogger(__name__)
3428

3529
__all__ = [
@@ -52,12 +46,6 @@ def get_variant_hashes_by_priority(
5246
use_auto_install: bool = True,
5347
isolated: bool = True,
5448
venv_path: str | pathlib.Path | None = None,
55-
namespace_priorities: list[VariantNamespace] | None = None,
56-
feature_priorities: dict[VariantNamespace, list[VariantFeatureName]] | None = None,
57-
property_priorities: dict[
58-
VariantNamespace, dict[VariantFeatureName, list[VariantFeatureValue]]
59-
]
60-
| None = None,
6149
) -> list[str]:
6250
supported_vprops = []
6351
if not isinstance(variants_json, VariantsJson):
@@ -86,17 +74,14 @@ def get_variant_hashes_by_priority(
8674
list(variants_json.variants.values()),
8775
supported_vprops,
8876
namespace_priorities=aggregate_namespace_priorities(
89-
namespace_priorities,
9077
config.namespace_priorities,
9178
variants_json.namespace_priorities,
9279
),
9380
feature_priorities=aggregate_feature_priorities(
94-
feature_priorities,
9581
config.feature_priorities,
9682
variants_json.feature_priorities,
9783
),
9884
property_priorities=aggregate_property_priorities(
99-
property_priorities,
10085
config.property_priorities,
10186
variants_json.property_priorities,
10287
),

0 commit comments

Comments
 (0)