Skip to content

Commit 4f2241a

Browse files
committed
Remove unused BasePluginLoader._call() method
1 parent bf352a2 commit 4f2241a

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

variantlib/plugins/loader.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@
1111
from pathlib import Path
1212
from subprocess import run
1313
from tempfile import TemporaryDirectory
14-
from types import MethodType
1514
from typing import TYPE_CHECKING
1615
from typing import Any
17-
from typing import get_type_hints
1816

1917
from packaging.markers import Marker
2018
from packaging.markers import default_environment
@@ -24,20 +22,15 @@
2422
from variantlib.errors import NoPluginFoundError
2523
from variantlib.errors import PluginError
2624
from variantlib.errors import PluginMissingError
27-
from variantlib.errors import ValidationError
2825
from variantlib.models.provider import ProviderConfig
2926
from variantlib.models.provider import VariantFeatureConfig
3027
from variantlib.plugins.py_envs import INSTALLER_PYTHON_ENVS
3128
from variantlib.plugins.py_envs import AutoPythonEnv
3229
from variantlib.plugins.py_envs import BasePythonEnv
3330
from variantlib.plugins.py_envs import ExternalNonIsolatedPythonEnv
34-
from variantlib.protocols import PluginType
3531
from variantlib.validators.base import validate_matches_re
36-
from variantlib.validators.base import validate_type
3732

3833
if TYPE_CHECKING:
39-
from collections.abc import Callable
40-
4134
from variantlib.models.metadata import VariantMetadata
4235
from variantlib.models.variant import VariantDescription
4336

@@ -179,24 +172,6 @@ def _load_all_plugins_from_tuple(self, plugin_apis: list[str]) -> None:
179172
"Impossible to load `%s`", plugin_api, exc_info=sys.exc_info()
180173
)
181174

182-
def _call(self, method: Callable[[], Any]) -> Any:
183-
"""Call plugin method and verify the return type"""
184-
185-
value = method()
186-
187-
try:
188-
validate_type(value, get_type_hints(method)["return"])
189-
except ValidationError as err:
190-
assert isinstance(method, MethodType)
191-
plugin_instance = method.__self__
192-
assert isinstance(plugin_instance, PluginType)
193-
raise TypeError(
194-
f"Provider {plugin_instance.namespace}, {method.__func__.__name__}() "
195-
f"method returned incorrect type. {err}"
196-
) from None
197-
198-
return value
199-
200175
def _check_plugins_loaded(self) -> None:
201176
if self._python_ctx is None:
202177
raise RuntimeError("Impossible to load plugins outside a Python Context")

0 commit comments

Comments
 (0)