api cleanups (#101)

* Remove `forbidden*` arguments to api

Remove the `forbidden*` arguments to `api` functions that aren't really
used and add unnecessary complexity.

* Remove priority arguments from `api`

Remove the unused `*prorities` parameters to `api` calls.  They are not
used and add unnecessarily complexity.  We are going to focus on config
+ package priorities instead.

Author: mgorny

variantlib/api.py

@@ -5,15 +5,13 @@
 import itertools
 import logging
 import pathlib
-from typing import TYPE_CHECKING
 
 from variantlib.configuration import VariantConfiguration
 from variantlib.constants import VARIANT_HASH_LEN
 from variantlib.constants import VariantsJsonDict
 from variantlib.models.provider import ProviderConfig
 from variantlib.models.provider import VariantFeatureConfig
 from variantlib.models.variant import VariantDescription
-from variantlib.models.variant import VariantFeature
 from variantlib.models.variant import VariantProperty
 from variantlib.models.variant import VariantValidationResult
 from variantlib.models.variant_info import VariantInfo
@@ -26,11 +24,6 @@
 from variantlib.variant_dist_info import VariantDistInfo
 from variantlib.variants_json import VariantsJson
 
-if TYPE_CHECKING:
-    from variantlib.protocols import VariantFeatureName
-    from variantlib.protocols import VariantFeatureValue
-    from variantlib.protocols import VariantNamespace
-
 logger = logging.getLogger(__name__)
 
 __all__ = [
@@ -53,15 +46,6 @@ def get_variant_hashes_by_priority(
     use_auto_install: bool = True,
     isolated: bool = True,
     venv_path: str | pathlib.Path | None = None,
-    namespace_priorities: list[VariantNamespace] | None = None,
-    feature_priorities: dict[VariantNamespace, list[VariantFeatureName]] | None = None,
-    property_priorities: dict[
-        VariantNamespace, dict[VariantFeatureName, list[VariantFeatureValue]]
-    ]
-    | None = None,
-    forbidden_namespaces: list[VariantNamespace] | None = None,
-    forbidden_features: list[str] | None = None,
-    forbidden_properties: list[str] | None = None,
 ) -> list[str]:
     supported_vprops = []
     if not isinstance(variants_json, VariantsJson):
@@ -82,18 +66,6 @@ def get_variant_hashes_by_priority(
             )
         )
 
-    _forbidden_features = (
-        None
-        if forbidden_features is None
-        else [VariantFeature.from_str(vfeat) for vfeat in forbidden_features]
-    )
-
-    _forbidden_properties = (
-        None
-        if forbidden_properties is None
-        else [VariantProperty.from_str(vprop) for vprop in forbidden_properties]
-    )
-
     config = VariantConfiguration.get_config()
 
     return [
@@ -102,23 +74,17 @@ def get_variant_hashes_by_priority(
             list(variants_json.variants.values()),
             supported_vprops,
             namespace_priorities=aggregate_namespace_priorities(
-                namespace_priorities,
                 config.namespace_priorities,
                 variants_json.namespace_priorities,
             ),
             feature_priorities=aggregate_feature_priorities(
-                feature_priorities,
                 config.feature_priorities,
                 variants_json.feature_priorities,
             ),
             property_priorities=aggregate_property_priorities(
-                property_priorities,
                 config.property_priorities,
                 variants_json.property_priorities,
             ),
-            forbidden_namespaces=forbidden_namespaces,
-            forbidden_features=_forbidden_features,
-            forbidden_properties=_forbidden_properties,
         )
     ]
 
@@ -187,9 +153,6 @@ def check_variant_supported(
     use_auto_install: bool = True,
     isolated: bool = True,
     venv_path: str | pathlib.Path | None = None,
-    forbidden_namespaces: list[VariantNamespace] | None = None,
-    forbidden_features: list[str] | None = None,
-    forbidden_properties: list[str] | None = None,
 ) -> bool:
     """Check if variant description is supported
 
@@ -223,28 +186,13 @@ def check_variant_supported(
             )
         )
 
-    _forbidden_features = (
-        None
-        if forbidden_features is None
-        else [VariantFeature.from_str(vfeat) for vfeat in forbidden_features]
-    )
-
-    _forbidden_properties = (
-        None
-        if forbidden_properties is None
-        else [VariantProperty.from_str(vprop) for vprop in forbidden_properties]
-    )
-
     VariantConfiguration.get_config()
 
     return bool(
         list(
             filter_variants(
                 vdescs=[vdesc],
                 allowed_properties=supported_vprops,
-                forbidden_namespaces=forbidden_namespaces,
-                forbidden_features=_forbidden_features,
-                forbidden_properties=_forbidden_properties,
             )
         )
     )