Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page<> findMatchesFor should not require a transaction #6

Open
nealeu opened this issue Oct 31, 2012 · 1 comment
Open

Page<> findMatchesFor should not require a transaction #6

nealeu opened this issue Oct 31, 2012 · 1 comment
Assignees
@nealeu
Labels
bug
Milestone
1.0.x

Comments

@nealeu
Copy link
Member

nealeu commented Oct 31, 2012

Only the version returning an Iterator requires a transaction to be provided. This method erroneously picked up that constraint when it wasn't necessary.
@ghost ghost assigned nealeu Oct 31, 2012
nealeu pushed a commit that referenced this issue Oct 31, 2012
#6 Remove mandatory transaction from Page<> findMatchesFor(query)
ca1d2fc 
Only needed where we're returning an iterator which then operates
within the scope of a transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nealeu nealeu

Labels
bug
Projects
None yet
Milestone
1.0.x
Development

No branches or pull requests
2 participants
@nealeu and others