Generated properties can cause NullReferenceException

[slimshader]

Hi,

generated propertoes call Equals unconditionally on argument which can casue NUllRefernceException when field is currently null.

        public partial global::Locale SelectedLocale
        {
            get => field;
            set
            {
                if (!Equals(field, value)) /// <--- here
                {
                    field = value;
                    OnPropertyChanged(_selectedLocaleChangedEventArgs);
                }
            }
        }

it should use Equality Comparer instead (from similar generator in MVVToolkit)

        [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator", "8.3.0.0")]
        [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
        public string PageInfo
        {
            get => _pageInfo;
            [global::System.Diagnostics.CodeAnalysis.MemberNotNull("_pageInfo")]
            set
            {
                if (!global::System.Collections.Generic.EqualityComparer<string>.Default.Equals(_pageInfo, value))
                {
                    OnPageInfoChanging(value);
                    OnPageInfoChanging(default, value);
                    OnPropertyChanging(global::CommunityToolkit.Mvvm.ComponentModel.__Internals.__KnownINotifyPropertyChangingArgs.PageInfo);
                    _pageInfo = value;
                    OnPageInfoChanged(value);
                    OnPageInfoChanged(default, value);
                    OnPropertyChanged(global::CommunityToolkit.Mvvm.ComponentModel.__Internals.__KnownINotifyPropertyChangedArgs.PageInfo);
                }
            }
        }

[slimshader]

Our system attempted to address this issue:

Modified property generation to use EqualityComparer.Default.Equals instead of direct Equals call to prevent potential NullReferenceException when field value is null. This follows the pattern used in MVVMToolkit.

You can examine the suggested modifications here: nxnen8282@752544a.

Caution

Advisory: This solution was generated using automated tools, and we strongly recommend reviewing the code thoroughly before implementation. The solution may be partial - please consider it as inspiration for your own implementation.

http://missionfixinternet.com

yup, this fix looks good