Skip to content

Commit 01f3e24

Browse files
authored
Merge branch 'main' into yearInReview_design
2 parents 9a64fc9 + 1e9d43b commit 01f3e24

File tree

87 files changed

+1142
-1143
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+1142
-1143
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ android {
3838
applicationId 'org.wikipedia'
3939
minSdk 21
4040
targetSdk 35
41-
versionCode 50527
41+
versionCode 50528
4242
testApplicationId 'org.wikipedia.test'
4343
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
4444
testInstrumentationRunnerArguments clearPackageData: 'true'

app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,9 @@
152152
android:theme="@style/AppTheme.ActionBar"
153153
android:configChanges="orientation|keyboardHidden|keyboard|screenSize" />
154154
<activity
155-
android:name=".language.LanguagesListActivity"
156-
android:label="@string/languages_list_activity_title"
157-
android:theme="@style/AppTheme.ActionBar"
158-
android:configChanges="orientation|keyboardHidden|keyboard|screenSize" />
155+
android:name=".language.addlanguages.AddLanguagesListActivity"
156+
android:windowSoftInputMode="adjustResize"
157+
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"/>
159158
<activity
160159
android:name=".suggestededits.SuggestionsActivity"
161160
android:launchMode="singleTask"

app/src/main/java/org/wikipedia/activity/BaseActivity.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import org.wikipedia.WikipediaApp
2424
import org.wikipedia.analytics.BreadcrumbsContextHelper
2525
import org.wikipedia.analytics.eventplatform.BreadCrumbLogEvent
2626
import org.wikipedia.analytics.eventplatform.EventPlatformClient
27-
import org.wikipedia.analytics.eventplatform.NotificationInteractionEvent
2827
import org.wikipedia.analytics.metricsplatform.MetricsPlatform
2928
import org.wikipedia.appshortcuts.AppShortcuts
3029
import org.wikipedia.auth.AccountUtil
@@ -96,9 +95,6 @@ abstract class BaseActivity : AppCompatActivity(), ConnectionStateMonitor.Callba
9695
}
9796

9897
supportActionBar?.setDisplayHomeAsUpEnabled(true)
99-
if (savedInstanceState == null) {
100-
NotificationInteractionEvent.processIntent(intent)
101-
}
10298

10399
// Conditionally execute all recurring tasks
104100
RecurringTasksExecutor().run()

app/src/main/java/org/wikipedia/analytics/eventplatform/CustomizeToolbarEvent.kt

Lines changed: 0 additions & 32 deletions
This file was deleted.

app/src/main/java/org/wikipedia/analytics/eventplatform/EditHistoryInteractionEvent.kt

Lines changed: 0 additions & 103 deletions
This file was deleted.

app/src/main/java/org/wikipedia/analytics/eventplatform/NotificationInteractionEvent.kt

Lines changed: 0 additions & 76 deletions
This file was deleted.

app/src/main/java/org/wikipedia/analytics/eventplatform/UserContributionEvent.kt

Lines changed: 0 additions & 77 deletions
This file was deleted.

app/src/main/java/org/wikipedia/bridge/JavaScriptActionHandler.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import org.wikipedia.R
77
import org.wikipedia.WikipediaApp
88
import org.wikipedia.auth.AccountUtil
99
import org.wikipedia.dataclient.WikiSite
10+
import org.wikipedia.extensions.getStrings
1011
import org.wikipedia.json.JsonUtil
1112
import org.wikipedia.page.Namespace
1213
import org.wikipedia.page.PageTitle
@@ -15,7 +16,6 @@ import org.wikipedia.settings.Prefs
1516
import org.wikipedia.util.DimenUtil
1617
import org.wikipedia.util.DimenUtil.densityScalar
1718
import org.wikipedia.util.DimenUtil.leadImageHeightForDevice
18-
import org.wikipedia.util.L10nUtil
1919
import java.util.Date
2020
import java.util.Locale
2121
import java.util.concurrent.TimeUnit
@@ -90,7 +90,7 @@ object JavaScriptActionHandler {
9090
fun setUp(context: Context, title: PageTitle, isPreview: Boolean, toolbarMargin: Int): String {
9191
val app = WikipediaApp.instance
9292
val topActionBarHeight = if (isPreview) 0 else DimenUtil.roundedPxToDp(toolbarMargin.toFloat())
93-
val res = L10nUtil.getStringsForArticleLanguage(title, intArrayOf(R.string.description_edit_add_description,
93+
val res = context.getStrings(title, intArrayOf(R.string.description_edit_add_description,
9494
R.string.table_infobox, R.string.table_other, R.string.table_close))
9595
val leadImageHeight = if (isPreview) 0 else
9696
(if (DimenUtil.isLandscape(context) || !Prefs.isImageDownloadEnabled) 0 else (leadImageHeightForDevice(context) / densityScalar).roundToInt() - topActionBarHeight)

app/src/main/java/org/wikipedia/compose/theme/WikipediaTypography.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ val Typography = WikipediaTypography(
4141
),
4242
h3 = TextStyle(
4343
fontFamily = FontFamily.SansSerif,
44-
fontWeight = FontWeight.Medium,
44+
fontWeight = FontWeight.Bold,
4545
fontSize = 16.sp,
4646
lineHeight = 24.sp
4747
),
@@ -57,6 +57,11 @@ val Typography = WikipediaTypography(
5757
fontSize = 12.sp,
5858
lineHeight = 18.sp
5959
),
60+
p = TextStyle(
61+
fontFamily = FontFamily.SansSerif,
62+
fontSize = 16.sp,
63+
lineHeight = 24.sp
64+
),
6065
button = TextStyle(
6166
fontFamily = FontFamily.SansSerif,
6267
fontWeight = FontWeight.Medium,

app/src/main/java/org/wikipedia/descriptions/DescriptionEditViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class DescriptionEditViewModel(savedStateHandle: SavedStateHandle) : ViewModel()
170170
var text = firstRevision?.contentMain.orEmpty()
171171
val baseRevId = firstRevision?.revId ?: 0
172172
text = updateDescriptionInArticle(text, currentDescription)
173-
val automaticallyAddedEditSummary = L10nUtil.getStringForArticleLanguage(pageTitle,
173+
val automaticallyAddedEditSummary = L10nUtil.getString(pageTitle,
174174
if (pageTitle.description.isNullOrEmpty()) R.string.edit_summary_added_short_description
175175
else R.string.edit_summary_updated_short_description)
176176
var editSummary = automaticallyAddedEditSummary

0 commit comments

Comments
 (0)