Skip to content

Commit 570d36e

Browse files
Remove ChunkAccess, ChunkCache
All of this has been dead code since the work to dispatch changes via jobs; specifically, the last use of ChunkCache was removed in change Ia9bf356584 (commit 008989a) and the last reference to ChunkAccess in change Icef4da7e47 (commit 8a502ad). testLoadByChangeIds() has to be rewritten to no longer depend on testLoadChunk() (which previously inserted test data used by both tests); as part of this, we can also simplify assertChangesEqual() now. Bug: T292604 Change-Id: I7ad46c10be59a362245c8979f744462687bff3be
1 parent 09ba20e commit 570d36e

File tree

7 files changed

+10
-679
lines changed

7 files changed

+10
-679
lines changed

.phpcs.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@
107107
</rule>
108108
<rule ref="MediaWiki.Usage.ForbiddenFunctions.assert">
109109
<exclude-pattern>ItemChangeTest\.php</exclude-pattern>
110-
<exclude-pattern>ChunkCache\.php</exclude-pattern>
111110
</rule>
112111
<rule ref="MediaWiki.Usage.ForbiddenFunctions.shell_exec">
113112
<exclude-pattern>PidLock\.php</exclude-pattern>

lib/includes/Store/ChunkAccess.php

Lines changed: 0 additions & 34 deletions
This file was deleted.

lib/includes/Store/ChunkCache.php

Lines changed: 0 additions & 301 deletions
This file was deleted.

0 commit comments

Comments
 (0)