GQL: Support time value type

Bug: T404838
Change-Id: I4cb695a252011c78839b48727bef106648d39a9d

Author: jakobw

repo/WikibaseRepo.datatypes.php

@@ -398,6 +398,25 @@
 					new ComplexValueRdfHelper( $vocab, $writer->sub(), $dedupe ) : null;
 				return new TimeRdfBuilder( $dateCleaner, $complexValueHelper );
 			},
+			'graphql-value-type' => static function () {
+				return new ObjectType( [
+					'name' => 'TimeValue',
+					'fields' => [
+						'time' => Type::nonNull( Type::string() ),
+						'timezone' => Type::nonNull( Type::int() ),
+						'before' => Type::nonNull( Type::int() ),
+						'after' => Type::nonNull( Type::int() ),
+						'precision' => Type::nonNull( Type::int() ),
+						'calendarModel' => Type::nonNull( Type::string() ),
+					],
+					'resolveField' => function ( Statement|PropertyValuePair $valueProvider, $args, $context, ResolveInfo $info ) {
+						$value = $valueProvider->value->content->getArrayValue();
+						$value['calendarModel'] = $value['calendarmodel'] ?? null; // prefer camel case over all lowercase
+
+						return $value[$info->fieldName] ?? null;
+					},
+				] );
+			},
 		],
 		'PT:url' => [
 			'validator-factory-callback' => function() {

repo/domains/reuse/src/Infrastructure/GraphQL/schema.graphql

@@ -52,7 +52,7 @@ type PredicateProperty {
   label(languageCode: LanguageCode!): String
 }
 
-union Value = StringValue | ItemValue | GlobeCoordinateValue | MonolingualTextValue | QuantityValue
+union Value = StringValue | ItemValue | GlobeCoordinateValue | MonolingualTextValue | QuantityValue | TimeValue
 
 type StringValue {
   content: String!
@@ -82,6 +82,15 @@ type QuantityValue {
   upperBound: String
 }
 
+type TimeValue {
+  time: String!
+  timezone: Int!
+  before: Int!
+  after: Int!
+  precision: Int!
+  calendarModel: String!
+}
+
 enum ValueType {
   novalue
   somevalue

repo/domains/reuse/tests/phpunit/Infrastructure/GraphQL/GraphQLServiceTest.php

@@ -8,6 +8,7 @@
 use DataValues\MonolingualTextValue;
 use DataValues\QuantityValue;
 use DataValues\StringValue;
+use DataValues\TimeValue;
 use DataValues\UnboundedQuantityValue;
 use Generator;
 use GraphQL\GraphQL;
@@ -54,6 +55,7 @@ class GraphQLServiceTest extends MediaWikiIntegrationTestCase {
 	private static Property $globeCoordinateTypeProperty;
 	private static Property $monolingualTextProperty;
 	private static Property $quantityProperty;
+	private static Property $timeProperty;
 	private static Property $qualifierProperty;
 	private static MediaWikiSite $sitelinkSite;
 	private const ALLOWED_SITELINK_SITES = [ 'examplewiki', 'otherwiki' ];
@@ -91,6 +93,7 @@ public function testQuery( string $query, array $expectedResult ): void {
 			self::$globeCoordinateTypeProperty,
 			self::$monolingualTextProperty,
 			self::$quantityProperty,
+			self::$timeProperty,
 		] as $property ) {
 			$dataTypeLookup->setDataTypeForProperty( $property->getId(), $property->getDataTypeId() );
 		}
@@ -136,6 +139,7 @@ public function queryProvider(): Generator {
 		$statementWithGlobeCoordinateValuePropertyId = 'P6';
 		$statementWithMonolingualTextValuePropertyId = 'P7';
 		$statementWithQuantityValuePropertyId = 'P8';
+		$statementWithTimeValuePropertyId = 'P9';
 		$statementWithItemValueQualifierPropertyId = $statementWithItemValuePropertyId; // also type wikibase-item so we can just reuse it.
 		$statementReferencePropertyId = 'P11';
 		$unusedPropertyId = 'P9999';
@@ -182,6 +186,18 @@ public function queryProvider(): Generator {
 			->withGuid( "$itemId\$a82559b1-da8f-4e02-9f72-e304b90a9bde" )
 			->withValue( $unboundedQuantityValue )
 			->build();
+		$timeValue = new TimeValue(
+			timestamp: '+2001-01-01T00:00:00Z',
+			timezone: 60,
+			before: 0,
+			after: 1,
+			precision: TimeValue::PRECISION_MONTH,
+			calendarModel: 'http://www.wikidata.org/entity/Q1985727',
+		);
+		$statementWithTimeValue = NewStatement::forProperty( $statementWithTimeValuePropertyId )
+			->withGuid( "$itemId\$a82559b1-da8f-4e02-9f72-e304b90a9bde" )
+			->withValue( $timeValue )
+			->build();
 
 		$statementWithNoValue = NewStatement::noValueFor( ( $statementWithNoValuePropertyId ) )
 			->withGuid( "$itemId\$bed933b7-4207-d679-7571-3630cfb49d9f" )
@@ -216,6 +232,11 @@ public function queryProvider(): Generator {
 			null,
 			'quantity',
 		);
+		self::$timeProperty = new Property(
+			new NumericPropertyId( $statementWithTimeValuePropertyId ),
+			null,
+			'time',
+		);
 		self::$qualifierProperty = new Property(
 			new NumericPropertyId( $qualifierPropertyId ),
 			new Fingerprint( new TermList( [ new Term( 'en', 'qualifier prop' ) ] ) ),
@@ -233,6 +254,7 @@ public function queryProvider(): Generator {
 			->andStatement( $statementWithMonolingualTextValue )
 			->andStatement( $statementWithQuantityValue )
 			->andStatement( $statementWithUnboundedQuantityValue )
+			->andStatement( $statementWithTimeValue )
 			->andStatement( $statementWithNoValue )
 			->andStatement( $statementWithSomeValue )
 			->build();
@@ -500,6 +522,33 @@ public function queryProvider(): Generator {
 				],
 			],
 		];
+		yield 'statement with time value' => [
+			"{ item(id: \"$itemId\") {
+				statements(propertyId: \"$statementWithTimeValuePropertyId\") {
+					value {
+						... on TimeValue { time timezone before after precision calendarModel }
+					}
+				}
+			} }",
+			[
+				'data' => [
+					'item' => [
+						'statements' => [
+							[
+								'value' => [
+									'time' => $timeValue->getTime(),
+									'timezone' => $timeValue->getTimezone(),
+									'before' => $timeValue->getBefore(),
+									'after' => $timeValue->getAfter(),
+									'precision' => $timeValue->getPrecision(),
+									'calendarModel' => $timeValue->getCalendarModel(),
+								],
+							],
+						],
+					],
+				],
+			],
+		];
 		yield 'statements with novalue and somevalue' => [
 			"{ item(id: \"$itemId\") {
 				$statementWithSomeValuePropertyId: statements(propertyId: \"$statementWithSomeValuePropertyId\") {