Remove groups from DomainDb and co

We are fully deprecating concept of groups in rdbms library

Bug: T405087
Change-Id: I20450a1f2c28ab443ee198939e7ee4aaddff556c

Author: Ladsgroup

client/WikibaseClient.ServiceWiring.php

@@ -102,7 +102,6 @@
 use Wikibase\Lib\MessageInLanguageProvider;
 use Wikibase\Lib\PropertyInfoDataTypeLookup;
 use Wikibase\Lib\Rdbms\ClientDomainDbFactory;
-use Wikibase\Lib\Rdbms\DomainDb;
 use Wikibase\Lib\Rdbms\RepoDomainDbFactory;
 use Wikibase\Lib\Rdbms\TermsDomainDbFactory;
 use Wikibase\Lib\Rdbms\VirtualTermsDomainDb;
@@ -203,8 +202,7 @@
 		$lbFactory = $services->getDBLoadBalancerFactory();
 
 		return new ClientDomainDbFactory(
-			$lbFactory,
-			[ DomainDb::LOAD_GROUP_FROM_CLIENT ]
+			$lbFactory
 		);
 	},
 
@@ -832,8 +830,7 @@ function ( EntityNamespaceLookup $nsLookup, DatabaseEntitySource $source ): Enti
 
 		return new RepoDomainDbFactory(
 			$lbFactory,
-			WikibaseClient::getItemAndPropertySource( $services )->getDatabaseName() ?: $lbFactory->getLocalDomainID(),
-			[ DomainDb::LOAD_GROUP_FROM_CLIENT ]
+			WikibaseClient::getItemAndPropertySource( $services )->getDatabaseName() ?: $lbFactory->getLocalDomainID()
 		);
 	},
 

client/tests/phpunit/integration/includes/Usage/Sql/EntityUsageTableBuilderTest.php

@@ -10,7 +10,6 @@
 use Wikibase\Client\Usage\Sql\EntityUsageTableBuilder;
 use Wikibase\DataModel\Entity\ItemIdParser;
 use Wikibase\Lib\Rdbms\ClientDomainDbFactory;
-use Wikibase\Lib\Rdbms\DomainDb;
 use Wikibase\Lib\Reporting\ExceptionHandler;
 use Wikimedia\Rdbms\LBFactorySingle;
 
@@ -38,8 +37,7 @@ public function testFillUsageTable(): void {
 		] );
 
 		$domainDbFactory = new ClientDomainDbFactory(
-			LBFactorySingle::newFromConnection( $this->db ),
-			[ DomainDb::LOAD_GROUP_FROM_CLIENT ]
+			LBFactorySingle::newFromConnection( $this->db )
 		);
 
 		$primer = new EntityUsageTableBuilder(

lib/includes/Rdbms/ClientDomainDbFactory.php

@@ -13,23 +13,16 @@ class ClientDomainDbFactory {
 
 	private ILBFactory $lbFactory;
 
-	/**
-	 * @var string[]
-	 */
-	private array $loadGroups;
-
-	public function __construct( ILBFactory $lbFactory, array $loadGroups = [] ) {
+	public function __construct( ILBFactory $lbFactory ) {
 		$this->lbFactory = $lbFactory;
-		$this->loadGroups = $loadGroups;
 	}
 
 	public function newLocalDb(): ClientDomainDb {
 		$localDomain = $this->lbFactory->getLocalDomainID();
 
 		return new ClientDomainDb(
 			$this->lbFactory,
-			$localDomain,
-			$this->loadGroups
+			$localDomain
 		);
 	}
 

lib/includes/Rdbms/DomainDb.php

@@ -21,10 +21,6 @@
  * @license GPL-2.0-or-later
  */
 abstract class DomainDb {
-
-	public const LOAD_GROUP_FROM_CLIENT = 'from-client';
-	public const LOAD_GROUP_FROM_REPO = 'from-repo';
-
 	private ILBFactory $lbFactory;
 	private string $domainId;
 	private ReplicationWaiter $replicationWaiter;
@@ -37,10 +33,9 @@ abstract class DomainDb {
 	private ?SessionConsistentConnectionManager $sessionConsistentConnectionManager = null;
 	private ?ConnectionManager $connectionManager = null;
 
-	public function __construct( ILBFactory $lbFactory, string $domainId, array $loadGroups = [] ) {
+	public function __construct( ILBFactory $lbFactory, string $domainId ) {
 		$this->lbFactory = $lbFactory;
 		$this->domainId = $domainId;
-		$this->loadGroups = $loadGroups;
 
 		$this->replicationWaiter = new ReplicationWaiter(
 			$lbFactory,
@@ -56,8 +51,7 @@ public function sessionConsistentConnections(): SessionConsistentConnectionManag
 		if ( $this->sessionConsistentConnectionManager === null ) {
 			$this->sessionConsistentConnectionManager = new SessionConsistentConnectionManager(
 				$this->lbFactory->getMainLB( $this->domainId ),
-				$this->domainId,
-				$this->loadGroups
+				$this->domainId
 			);
 		}
 		return $this->sessionConsistentConnectionManager;
@@ -71,8 +65,7 @@ public function connections(): ConnectionManager {
 		if ( $this->connectionManager === null ) {
 			$this->connectionManager = new ConnectionManager(
 				$this->lbFactory->getMainLB( $this->domainId ),
-				$this->domainId,
-				$this->loadGroups
+				$this->domainId
 			);
 		}
 		return $this->connectionManager;

lib/includes/Rdbms/RepoDomainDbFactory.php

@@ -15,19 +15,12 @@ class RepoDomainDbFactory {
 	private string $repoDomain;
 	private ILBFactory $lbFactory;
 
-	/**
-	 * @var string[]
-	 */
-	private array $loadGroups;
-
 	public function __construct(
 		ILBFactory $lbFactory,
-		string $repoDomain,
-		array $loadGroups = []
+		string $repoDomain
 	) {
 		$this->lbFactory = $lbFactory;
 		$this->repoDomain = $repoDomain;
-		$this->loadGroups = $loadGroups;
 	}
 
 	/**
@@ -46,11 +39,7 @@ public function newForEntitySource( DatabaseEntitySource $entitySource ): RepoDo
 	}
 
 	private function newForDomain( string $domainId ): RepoDomainDb {
-		return new RepoDomainDb(
-			$this->lbFactory,
-			$domainId,
-			$this->loadGroups
-		);
+		return new RepoDomainDb( $this->lbFactory, $domainId );
 	}
 
 }

repo/WikibaseRepo.ServiceWiring.php

@@ -89,7 +89,6 @@
 use Wikibase\Lib\Normalization\SnakNormalizer;
 use Wikibase\Lib\Normalization\StatementNormalizer;
 use Wikibase\Lib\Normalization\StringValueNormalizer;
-use Wikibase\Lib\Rdbms\DomainDb;
 use Wikibase\Lib\Rdbms\RepoDomainDbFactory;
 use Wikibase\Lib\Rdbms\TermsDomainDbFactory;
 use Wikibase\Lib\Rdbms\VirtualTermsDomainDb;
@@ -1761,8 +1760,7 @@ function ( $types, $localTypeName ) use ( $subEntityTypes ) {
 
 		return new RepoDomainDbFactory(
 			$lbFactory,
-			$lbFactory->getLocalDomainID(),
-			[ DomainDb::LOAD_GROUP_FROM_REPO ]
+			$lbFactory->getLocalDomainID()
 		);
 	},