Remove deprecated getEntityParserOutputGenerator function

All callers of the deprecated `getEntityParserOutputGenerator`
function have been removed - also remove the function from the
EntityParserOutputGeneratorFactory.

Depends-On: Ie4400ccbf2eac62b88b55a15749262ed5dbd8d33
Depends-On: Ib471dc6d78c1bc51638eb5ac0c2dabde834fd646
Depends-On: I8ccb870db6cf63e7641f241709c08b6aa2203358
Bug: T407737
Change-Id: Ic6183746d321ec3ee7ccbdf829dab9926a6a6964

Author: codders

repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php

@@ -135,34 +135,9 @@ private function getValidUserLanguage( Language $language ): Language {
 		return $language;
 	}
 
-	/**
-	 * Introduce this function to make it possible to transition the interface
-	 * for `getEntityParserOutputGenerator` from taking a Language to taking a ParserOptions
-	 * object.
-	 *
-	 * We introduce this new function, update callers to call the new function with the
-	 * new interface, then in future commits we will remove the old function.
-	 *
-	 * @param ParserOptions $options
-	 * @return EntityParserOutputGenerator
-	 */
 	public function getEntityParserOutputGeneratorForParserOptions( ParserOptions $options ): EntityParserOutputGenerator {
 		$userLanguage = $this->getValidUserLanguage( $options->getUserLangObj() );
-		$wbMobile = $options->getOption( 'wbMobile' );
-
-		return $this->getEntityParserOutputGenerator( $userLanguage, $wbMobile );
-	}
 
-	/**
-	 * @deprecated Remove this function in favour of the function version that takes
-	 * a ParserOptions object. When all callers of this function have migrated, the function
-	 * can be removed.
-	 *
-	 * @param Language $userLanguage
-	 * @param bool|string $wbMobile
-	 * @return EntityParserOutputGenerator
-	 */
-	public function getEntityParserOutputGenerator( Language $userLanguage, $wbMobile = false ): EntityParserOutputGenerator {
 		$pog = new FullEntityParserOutputGenerator(
 			$this->entityViewFactory,
 			$this->entityMetaTagsCreatorFactory,
@@ -171,7 +146,7 @@ public function getEntityParserOutputGenerator( Language $userLanguage, $wbMobil
 			$this->entityDataFormatProvider,
 			$this->getDataUpdaters(),
 			$userLanguage,
-			$wbMobile,
+			$options->getOption( 'wbMobile' ),
 			$this->isMobileView
 		);
 

repo/tests/phpunit/includes/ParserOutput/FullEntityParserOutputGeneratorIntegrationTest.php

@@ -3,6 +3,7 @@
 namespace Wikibase\Repo\Tests\ParserOutput;
 
 use DataValues\QuantityValue;
+use MediaWiki\Parser\ParserOptions;
 use MediaWiki\Parser\ParserOutputLinkTypes;
 use MediaWikiIntegrationTestCase;
 use Wikibase\DataModel\Entity\EntityIdValue;
@@ -103,8 +104,10 @@ public function testSetsViewChunksForEntityTermsView() {
 	}
 
 	private function newParserOutputGenerator() {
+		$parserOptions = ParserOptions::newFromAnon();
+		$parserOptions->setUserLang( $this->getServiceContainer()->getLanguageFactory()->getLanguage( 'en' ) );
 		return WikibaseRepo::getEntityParserOutputGeneratorFactory()
-			->getEntityParserOutputGenerator( $this->getServiceContainer()->getLanguageFactory()->getLanguage( 'en' ) );
+			->getEntityParserOutputGeneratorForParserOptions( $parserOptions );
 	}
 
 	private function saveItem( $id ) {
@@ -147,9 +150,12 @@ public function testGetParserOutputIncludesLabelsOfRedirectEntityUsedAsStatement
 		$store->saveRedirect( new EntityRedirect( $redirectSourceId, $redirectTargetId ), 'mistake', $user );
 		$revision = $store->saveEntity( $item, 'test item', $user );
 
-		$language = $mwServices->getLanguageFactory()->getLanguage( 'en' );
 		$entityParserOutputGeneratorFactory = WikibaseRepo::getEntityParserOutputGeneratorFactory( $mwServices );
-		$entityParserOutputGenerator = $entityParserOutputGeneratorFactory->getEntityParserOutputGenerator( $language );
+		$parserOptions = ParserOptions::newFromAnon();
+		$parserOptions->setUserLang( $mwServices->getLanguageFactory()->getLanguage( 'en' ) );
+		$entityParserOutputGenerator = $entityParserOutputGeneratorFactory->getEntityParserOutputGeneratorForParserOptions(
+			$parserOptions
+		);
 
 		$parserOutput = $entityParserOutputGenerator->getParserOutput( $revision );