GQL: Support globecoordinate value type

This allows retrieving statement values of type globecoordinate, which
includes values for latitude, longitude, precision and globe.

Bug: T404838
Change-Id: I62f1cb51a54a4dae283d72041ae4517a7b3bc3a2

Author: Silvan-WMDE

repo/WikibaseRepo.datatypes.php

@@ -32,6 +32,7 @@
 use DataValues\TimeValue;
 use DataValues\UnboundedQuantityValue;
 use GraphQL\Type\Definition\ObjectType;
+use GraphQL\Type\Definition\ResolveInfo;
 use GraphQL\Type\Definition\Type;
 use MediaWiki\Logger\LoggerFactory;
 use MediaWiki\MediaWikiServices;
@@ -210,6 +211,30 @@
 					new ComplexValueRdfHelper( $vocab, $writer->sub(), $dedupe ) : null;
 				return new GlobeCoordinateRdfBuilder( $complexValueHelper );
 			},
+			'graphql-value-type' => static function () {
+				return new ObjectType( [
+					'name' => 'GlobeCoordinateValue',
+					'fields' => [
+						'latitude' => Type::nonNull( Type::float() ),
+						'longitude' => Type::nonNull( Type::float() ),
+						'precision' => Type::float(),
+						'globe' => Type::nonNull( Type::string() ),
+					],
+					'resolveField' => function ( Statement|PropertyValuePair $valueProvider, $args, $context, ResolveInfo $info ) {
+						/** @var GlobeCoordinateValue $globeCoordinateValue */
+						$globeCoordinateValue = $valueProvider->value->content;
+						'@phan-var GlobeCoordinateValue $globeCoordinateValue';
+
+						return match ( $info->fieldName ) {
+							'latitude' => $globeCoordinateValue->getLatitude(),
+							'longitude' => $globeCoordinateValue->getLongitude(),
+							'precision' => $globeCoordinateValue->getPrecision(),
+							'globe' => $globeCoordinateValue->getGlobe(),
+							default => null,
+						};
+					},
+				] );
+			},
 		],
 		'VT:monolingualtext' => [
 			'expert-module' => 'jquery.valueview.experts.MonolingualText',

repo/domains/reuse/src/Infrastructure/GraphQL/schema.graphql

@@ -50,7 +50,7 @@ type PredicateProperty {
   label(languageCode: LanguageCode!): String
 }
 
-union Value = StringValue | ItemValue
+union Value = StringValue | ItemValue | GlobeCoordinateValue
 
 type StringValue {
   content: String!
@@ -65,6 +65,13 @@ type ValueItem {
   label(languageCode: LanguageCode!): String
 }
 
+type GlobeCoordinateValue {
+  latitude: Float!
+  longitude: Float!
+  precision: Float
+  globe: String!
+}
+
 enum ValueType {
   novalue
   somevalue

repo/domains/reuse/tests/phpunit/Infrastructure/GraphQL/GraphQLServiceTest.php

@@ -2,6 +2,8 @@
 
 namespace Wikibase\Repo\Tests\Domains\Reuse\Infrastructure\GraphQL;
 
+use DataValues\Geo\Values\GlobeCoordinateValue;
+use DataValues\Geo\Values\LatLongValue;
 use DataValues\StringValue;
 use Generator;
 use GraphQL\GraphQL;
@@ -45,6 +47,7 @@ class GraphQLServiceTest extends MediaWikiIntegrationTestCase {
 	private static Item $qualifierValueItem;
 	private static Property $stringTypeProperty;
 	private static Property $itemTypeProperty;
+	private static Property $globeCoordinateTypeProperty;
 	private static Property $qualifierProperty;
 	private static MediaWikiSite $sitelinkSite;
 	private const ALLOWED_SITELINK_SITES = [ 'examplewiki', 'otherwiki' ];
@@ -78,6 +81,7 @@ public function testQuery( string $query, array $expectedResult ): void {
 		$dataTypeLookup->setDataTypeForProperty( self::$stringTypeProperty->getId(), 'string' );
 		$dataTypeLookup->setDataTypeForProperty( self::$qualifierProperty->getId(), 'string' );
 		$dataTypeLookup->setDataTypeForProperty( self::$itemTypeProperty->getId(), 'wikibase-item' );
+		$dataTypeLookup->setDataTypeForProperty( self::$globeCoordinateTypeProperty->getId(), 'globe-coordinate' );
 
 		$this->assertEquals(
 			$expectedResult,
@@ -117,8 +121,9 @@ public function queryProvider(): Generator {
 		$statementWithNoValuePropertyId = 'P4';
 		$statementWithNoReferencesPropertyId = $statementWithNoValuePropertyId;
 		$statementWithSomeValuePropertyId = 'P5';
+		$statementWithGlobeCoordinateValuePropertyId = 'P6';
 		$statementWithItemValueQualifierPropertyId = $statementWithItemValuePropertyId; // also type wikibase-item so we can just reuse it.
-		$statementReferencePropertyId = 'P6';
+		$statementReferencePropertyId = 'P11';
 		$unusedPropertyId = 'P9999';
 		$qualifierStringValue = 'qualifierStringValue';
 		$statementStringValue = 'statementStringValue';
@@ -135,6 +140,11 @@ public function queryProvider(): Generator {
 			->withValue( new ItemId( $itemValueItemId ) )
 			->withQualifier( $statementWithItemValueQualifierPropertyId, self::$qualifierValueItem->getId() )
 			->build();
+		$globeCoordinateValue = new GlobeCoordinateValue( new LatLongValue( 52.516, 13.383 ) );
+		$statementWithGlobeCoordinateValue = NewStatement::forProperty( $statementWithGlobeCoordinateValuePropertyId )
+			->withGuid( "$itemId\$a82559b1-da8f-4e02-9f72-e304b90a9bde" )
+			->withValue( $globeCoordinateValue )
+			->build();
 
 		$statementWithNoValue = NewStatement::noValueFor( ( $statementWithNoValuePropertyId ) )
 			->withGuid( "$itemId\$bed933b7-4207-d679-7571-3630cfb49d9f" )
@@ -154,6 +164,11 @@ public function queryProvider(): Generator {
 			'string',
 		);
 		self::$itemTypeProperty = new Property( new NumericPropertyId( $statementWithItemValuePropertyId ), null, 'wikibase-item' );
+		self::$globeCoordinateTypeProperty = new Property(
+			new NumericPropertyId( $statementWithGlobeCoordinateValuePropertyId ),
+			null,
+			'globe-coordinate',
+		);
 		self::$qualifierProperty = new Property(
 			new NumericPropertyId( $qualifierPropertyId ),
 			new Fingerprint( new TermList( [ new Term( 'en', 'qualifier prop' ) ] ) ),
@@ -167,6 +182,7 @@ public function queryProvider(): Generator {
 			->andSiteLink( $sitelinkSiteId, $sitelinkTitle )
 			->andStatement( $statementWithStringValue )
 			->andStatement( $statementWithItemValue )
+			->andStatement( $statementWithGlobeCoordinateValue )
 			->andStatement( $statementWithNoValue )
 			->andStatement( $statementWithSomeValue )
 			->build();
@@ -355,6 +371,31 @@ public function queryProvider(): Generator {
 				],
 			],
 		];
+		yield 'statement with globe-coordinate value' => [
+			"{ item(id: \"$itemId\") {
+				statements(propertyId: \"$statementWithGlobeCoordinateValuePropertyId\") {
+					value {
+						... on GlobeCoordinateValue { latitude longitude precision globe }
+					}
+				}
+			} }",
+			[
+				'data' => [
+					'item' => [
+						'statements' => [
+							[
+								'value' => [
+									'latitude' => $globeCoordinateValue->getLatitude(),
+									'longitude' => $globeCoordinateValue->getLongitude(),
+									'precision' => $globeCoordinateValue->getPrecision(),
+									'globe' => $globeCoordinateValue->getGlobe(),
+								],
+							],
+						],
+					],
+				],
+			],
+		];
 		yield 'statements with novalue and somevalue' => [
 			"{ item(id: \"$itemId\") {
 				$statementWithSomeValuePropertyId: statements(propertyId: \"$statementWithSomeValuePropertyId\") {