Migrate WikibaseRepoEntitySearchHelperCallbacks hook

Apparently we previously hadn’t documented this one in hooks-php.md, so
add a pointer to the hook interface now. We might remove this file later
(not sure), but as long as we have it, I think it’s better if it lists
all the hooks.

Bug: T391444
Change-Id: I027fce3d1922d645f55b7f2b2725e5e66ecf9679

Author: lucaswerkmeister

docs/topics/hooks-php.md

@@ -48,6 +48,9 @@ See @ref Wikibase::Repo::Hooks::WikibaseRepoOnParserOutputUpdaterConstructionHoo
 #### GetEntityByLinkedTitleLookup {#GetEntityByLinkedTitleLookup}
 See @ref Wikibase::Repo::Hooks::GetEntityByLinkedTitleLookupHook.
 
+### WikibaseRepoEntitySearchHelperCallbacks {#WikibaseRepoEntitySearchHelperCallbacks}
+See @ref Wikibase::Repo::Hooks::WikibaseRepoEntitySearchHelperCallbacks.
+
 Client
 ------------------------------------------------------------
 

repo/WikibaseRepo.ServiceWiring.php

@@ -994,7 +994,8 @@ function ( EntityNamespaceLookup $nsLookup, DatabaseEntitySource $source ): Enti
 		$callbacks = WikibaseRepo::getEntityTypeDefinitions( $services )
 			->get( EntityTypeDefinitions::ENTITY_SEARCH_CALLBACK );
 
-		$services->getHookContainer()->run( 'WikibaseRepoEntitySearchHelperCallbacks', [ &$callbacks ] );
+		WikibaseRepo::getHookRunner( $services )
+			->onWikibaseRepoEntitySearchHelperCallbacks( $callbacks );
 
 		return $callbacks;
 	},

repo/includes/Hooks/WikibaseRepoEntitySearchHelperCallbacksHook.php

@@ -0,0 +1,32 @@
+<?php
+
+declare( strict_types = 1 );
+
+namespace Wikibase\Repo\Hooks;
+
+/**
+ * This is a hook handler interface, see docs/Hooks.md in MediaWiki core.
+ * Use the hook name "WikibaseRepoEntitySearchHelperCallbacks" to register
+ * handlers implementing this interface.
+ *
+ * @license GPL-2.0-or-later
+ */
+interface WikibaseRepoEntitySearchHelperCallbacksHook {
+
+	/**
+	 * Define or modify entity search helper callbacks.
+	 *
+	 * This hook is called when the entity search is initialized.
+	 * $callbacks is an associative array from entity type to callback:
+	 * each callback takes a {@link \MediaWiki\Request\WebRequest WebRequest} parameter
+	 * and returns an {@link \Wikibase\Repo\Api\EntitySearchHelper EntitySearchHelper}.
+	 * Usually, these callbacks are defined via the entity type definitions,
+	 * using the {@link \Wikibase\Lib\EntityTypeDefinitions::ENTITY_SEARCH_CALLBACK ENTITY_SEARCH_CALLBACK} key;
+	 * however, it is possible to change the callbacks via this hook,
+	 * or even to install additional searchable entity types that are not registered as entity types.
+	 *
+	 * @param callable[] &$callbacks
+	 */
+	public function onWikibaseRepoEntitySearchHelperCallbacks( array &$callbacks ): void;
+
+}

repo/includes/Hooks/WikibaseRepoHookRunner.php

@@ -23,6 +23,7 @@ class WikibaseRepoHookRunner implements
 	WikibaseChangeNotificationHook,
 	WikibaseContentModelMappingHook,
 	WikibaseRepoDataTypesHook,
+	WikibaseRepoEntitySearchHelperCallbacksHook,
 	WikibaseRepoEntityTypesHook,
 	WikibaseRepoOnParserOutputUpdaterConstructionHook,
 	WikibaseRepoSearchableEntityScopesMessagesHook,
@@ -82,6 +83,13 @@ public function onWikibaseRepoDataTypes( array &$dataTypeDefinitions ): void {
 		);
 	}
 
+	public function onWikibaseRepoEntitySearchHelperCallbacks( array &$callbacks ): void {
+		$this->hookContainer->run( 'WikibaseRepoEntitySearchHelperCallbacks',
+			[ &$callbacks ],
+			[ 'abortable' => false ]
+		);
+	}
+
 	public function onWikibaseRepoEntityTypes( array &$entityTypeDefinitions ): void {
 		/**
 		 * Warning: This hook runs as part of an early initialization service

repo/tests/phpunit/unit/ServiceWiring/EntitySearchHelperCallbacksTest.php

@@ -4,11 +4,8 @@
 
 namespace Wikibase\Repo\Tests\Unit\ServiceWiring;
 
-use MediaWiki\HookContainer\HookContainer;
-use MediaWiki\HookContainer\StaticHookRegistry;
 use Wikibase\Lib\EntityTypeDefinitions;
 use Wikibase\Repo\Tests\Unit\ServiceWiringTestCase;
-use Wikimedia\ObjectFactory\ObjectFactory;
 
 /**
  * @coversNothing
@@ -32,18 +29,13 @@ public function testConstruction(): void {
 					EntityTypeDefinitions::ENTITY_SEARCH_CALLBACK => $callable2,
 				],
 			] ) );
-		$this->serviceContainer->expects( $this->once() )
-			->method( 'getHookContainer' )
-			->willReturn( new HookContainer(
-				new StaticHookRegistry( [
-					'WikibaseRepoEntitySearchHelperCallbacks' => [
-						'callback' => function ( &$callbacks ) use ( $callable3 ) {
-							$callbacks['type3'] = $callable3;
-						},
-					],
-				] ),
-				$this->createMock( ObjectFactory::class )
-			) );
+		$this->configureHookRunner( [
+			'WikibaseRepoEntitySearchHelperCallbacks' => [
+				function ( &$callbacks ) use ( $callable3 ) {
+					$callbacks['type3'] = $callable3;
+				},
+			],
+		] );
 
 		$this->assertSame( [
 			'type1' => $callable1,