Skip to content

Commit dc83958

Browse files
coddersjenkins-bot
authored andcommitted
Update messages for statement editing
T404696 (I987ea3c052ad0a) introduced status messages when statement edits are submitted in the MEX / wbui2025 user interface. Update the messages per latest feedback from UX, and use translation strings everywhere Bug: T403011 Change-Id: I6a6a6964f61931f5210cd9c4d5aa3cf669d9a91d
1 parent 48157bc commit dc83958

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

repo/i18n/en.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@
3535
"wikibase-addreference": "add reference",
3636
"wikibase-save-inprogress": "Saving…",
3737
"wikibase-publish-inprogress": "Publishing…",
38-
"wikibase-publishing-progress": "Publishing in progress…",
38+
"wikibase-publishing-error": "Something went wrong saving your changes. Wait a moment and try again.",
39+
"wikibase-publishing-progress": "Finalizing your changes…",
40+
"wikibase-publishing-succeeded": "Your changes have been saved!",
3941
"wikibase-remove-inprogress": "Removing…",
4042
"wikibase-statementlistview-add": "add value",
4143
"wikibase-statementlistview-add-tooltip": "Add a new value",

repo/i18n/qqq.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@
7878
"wikibase-addreference": "Label of the link to add a reference to a statement (see [[d:Wikidata:Glossary]]).",
7979
"wikibase-save-inprogress": "[[File:Screenshot WikidataRepo 2012-05-25 L.png|right|350px]]\n[[File:Screenshot WikidataRepo 2012-05-25 J.png|right|350px]]\n[[File:Screenshot WikidataRepo 2012-05-25 K.png|right|350px]]\nThis is a generic placeholder message used while a save is in progress, and replaces the save and cancel links.\n{{Identical|Saving}}",
8080
"wikibase-publish-inprogress": "This is a generic placeholder message used while a saving and publishing is in progress, and replaces the publish and cancel links.",
81-
"wikibase-publishing-progress": "Message shown to the user in the edit statements modal when statements are being published. Appears above the progress bar.",
81+
"wikibase-publishing-error": "Message show to the user in an 'error' message box in the case that an attempt to publish changes to a statement failed",
82+
"wikibase-publishing-progress": "Message shown to the user in the edit statements modal when statements are being published and the publish action has taken longer than a certain period (300 milliseconds). Appears above the progress bar.",
83+
"wikibase-publishing-succeeded": "Message show to the user in a 'success' message box when updates to a statement have been successfully published and saved to the Wikibase",
8284
"wikibase-remove-inprogress": "[[File:Screenshot WikidataRepo 2012-05-25 L.png|right|350px]]\n[[File:Screenshot WikidataRepo 2012-05-25 M.png|right|350px]]\nThis is a generic placeholder message used while a remove is in progress, and replaces the edit and remove.\n{{Identical|Removing}}",
8385
"wikibase-statementlistview-add": "This is a text used for a link that allows the user to add a new statement with the existing property id.",
8486
"wikibase-statementlistview-add-tooltip": "This is a tooltip text used for a link that allows the user to add a new statement with the existing property id.",

repo/includes/RepoHooks.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,6 @@ public function onResourceLoaderRegisterModules( $rl ): void {
908908
'wikibase-aliases-edit-placeholder',
909909
'wikibase-aliases-edit-placeholder-language-aware',
910910
'wikibase-aliases-edit-placeholder-mul',
911-
'wikibase-publishing-progress',
912911
],
913912
],
914913
];
@@ -1046,7 +1045,9 @@ public function onResourceLoaderRegisterModules( $rl ): void {
10461045
'wikibase-edit',
10471046
'wikibase-entityselector-notfound',
10481047
'wikibase-publish',
1048+
'wikibase-publishing-error',
10491049
'wikibase-publishing-progress',
1050+
'wikibase-publishing-succeeded',
10501051
'wikibase-remove',
10511052
'wikibase-save',
10521053
'wikibase-snakview-property-input-placeholder',

repo/resources/wikibase.wbui2025/wikibase.wbui2025.editStatementGroup.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,12 +180,12 @@ module.exports = exports = defineComponent( {
180180
this.disposeOfEditableStatementStores();
181181
this.addStatusMessage( {
182182
type: 'success',
183-
text: 'Success: Your statement was published'
183+
text: mw.msg( 'wikibase-publishing-succeeded' )
184184
} );
185185
} )
186186
.catch( () => {
187187
this.addStatusMessage( {
188-
text: 'An error occurred while saving. Please try again.'
188+
text: mw.msg( 'wikibase-publishing-error' )
189189
} );
190190
this.formSubmitted = false;
191191
} );

0 commit comments

Comments
 (0)