CSVUnitStorage: Change escape to future default of ""

lucaswerkmeister · jenkins-bot · commit e964229ac709 · 2025-10-23T16:00:45.000Z
PHP plans to change the default value of this parameter from "\\" to "", as the old default apparently has problems. CSV unit files only contain item IDs (Q[1-9][0-9]*) and floats anyways, so there should be no need for any escaping, and we might as well use the upcoming default already. Bug: T386113 Change-Id: I7d00ba49bb567caab1a58753995424d551441cf7 Follows-Up: I7c2309f348335f36870ec4dd8ed8c9e727711a59
diff --git a/lib/includes/Units/CSVUnitStorage.php b/lib/includes/Units/CSVUnitStorage.php
@@ -39,7 +39,7 @@ protected function loadStorageData() {
 			return null;
 		}
 		$data = [];
-		for ( $row = fgetcsv( $f, 0, ',', '"', "\\" ); $row !== false; $row = fgetcsv( $f, 0, ',', '"', "\\" ) ) {
+		for ( $row = fgetcsv( $f, 0, ',', '"', "" ); $row !== false; $row = fgetcsv( $f, 0, ',', '"', "" ) ) {
 			// @phan-suppress-next-line PhanTypeMismatchDimAssignment False positive
 			$data[$row[0]] = array_slice( $row, 1 );
 		}

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ protected function loadStorageData() {`
`39`	`39`	`return null;`
`40`	`40`	`}`
`41`	`41`	`$data = [];`
`42`		`- for ( $row = fgetcsv( $f, 0, ',', '"', "\\" ); $row !== false; $row = fgetcsv( $f, 0, ',', '"', "\\" ) ) {`
	`42`	`+ for ( $row = fgetcsv( $f, 0, ',', '"', "" ); $row !== false; $row = fgetcsv( $f, 0, ',', '"', "" ) ) {`
`43`	`43`	`// @phan-suppress-next-line PhanTypeMismatchDimAssignment False positive`
`44`	`44`	`$data[$row[0]] = array_slice( $row, 1 );`
`45`	`45`	`}`