Skip to content

Commit f07b097

Browse files
jenkins-botGerrit Code Review
authored andcommitted
Merge "build: Use inline ignore for MediaWiki.Usage.ForbiddenFunctions"
2 parents b454789 + c880fb5 commit f07b097

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.phpcs.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,6 @@
9090
<rule ref="MediaWiki.Commenting.PhpunitAnnotations.NotClassTrait">
9191
<exclude-pattern>DispatchingQueryBuilderTest\.php</exclude-pattern>
9292
</rule>
93-
<rule ref="MediaWiki.Usage.ForbiddenFunctions.assert">
94-
<exclude-pattern>ItemChangeTest\.php</exclude-pattern>
95-
</rule>
96-
<rule ref="MediaWiki.Usage.ForbiddenFunctions.shell_exec">
97-
<exclude-pattern>PidLock\.php</exclude-pattern>
98-
</rule>
9993
<rule ref="MediaWiki.Arrays.TrailingComma">
10094
<properties>
10195
<property name="singleLine" value="false" />

lib/packages/wikibase/changes/tests/ItemChangeTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ public static function changeBackwardsCompatProvider() {
8484
] );
8585

8686
// make sure we got the right key for sitelinks
87+
// phpcs:ignore MediaWiki.Usage.ForbiddenFunctions.assert
8788
assert( $diff->getSiteLinkDiff() !== null );
8889

8990
//NOTE: ItemChange's constructor may or may not already fix the bad diff.

0 commit comments

Comments
 (0)