Search: Delete sqlTermStoreSearchEngine

This patch does the following as well:

* Updates the README that Elastic search configured is a requirement for the RESTful search to work

Bug: T397137
Change-Id: Ia8f5f6c12ca8606dd49a11d521479de556bd9751

Author: dima koushha

repo/domains/search/src/Infrastructure/DataAccess/SqlTermStoreSearchEngine.php

@@ -14,8 +14,6 @@
 use Wikibase\Repo\Domains\Search\Application\Validation\SearchLanguageValidator;
 use Wikibase\Repo\Domains\Search\Infrastructure\DataAccess\EntitySearchHelperPrefixSearchEngine;
 use Wikibase\Repo\Domains\Search\Infrastructure\DataAccess\InLabelSearchEngine;
-use Wikibase\Repo\Domains\Search\Infrastructure\DataAccess\SqlTermStoreSearchEngine;
-use Wikibase\Repo\Domains\Search\Infrastructure\DataAccess\TermRetriever;
 use Wikibase\Repo\Domains\Search\Infrastructure\LanguageCodeValidator;
 use Wikibase\Repo\Domains\Search\WbSearch;
 use Wikibase\Repo\RestApi\Middleware\MiddlewareHandler;
@@ -78,39 +76,17 @@
 		] );
 	},
 
-	/**
-	 * @return InLabelSearchEngine|SqlTermStoreSearchEngine
-	 */
-	'WbSearch.SearchEngine' => function( MediaWikiServices $services ) {
-		global $wgSearchType;
-
-		$isWikibaseCirrusSearchEnabled = $services->getExtensionRegistry()->isLoaded( 'WikibaseCirrusSearch' );
-		$isCirrusSearchEnabled = $wgSearchType === 'CirrusSearch';
-
-		$searchEngine = $isCirrusSearchEnabled && $isWikibaseCirrusSearchEnabled
-			? WbSearch::getInLabelSearchEngine( $services )
-			: new SqlTermStoreSearchEngine(
-				WikibaseRepo::getMatchingTermsLookupFactory( $services )
-					->getLookupForSource( WikibaseRepo::getLocalEntitySource( $services ) ),
-				WikibaseRepo::getEntityLookup( $services ),
-				new TermRetriever( WikibaseRepo::getFallbackLabelDescriptionLookupFactory( $services ), $services->getLanguageFactory() ),
-				WikibaseRepo::getLanguageFallbackChainFactory( $services )
-			);
-
-		return $searchEngine;
-	},
-
 	'WbSearch.SimpleItemSearch' => function( MediaWikiServices $services ): SimpleItemSearch {
 		return new SimpleItemSearch(
 			new SimpleItemSearchValidator( WbSearch::getLanguageCodeValidator( $services ) ),
-			WbSearch::getSearchEngine( $services )
+			WbSearch::getInLabelSearchEngine( $services )
 		);
 	},
 
 	'WbSearch.SimplePropertySearch' => function( MediaWikiServices $services ): SimplePropertySearch {
 		$validator = new SimplePropertySearchValidator( WbSearch::getLanguageCodeValidator( $services ) );
 
-		return new SimplePropertySearch( $validator, WbSearch::getSearchEngine( $services )
+		return new SimplePropertySearch( $validator, WbSearch::getInLabelSearchEngine( $services )
 		);
 	},
 

repo/domains/search/src/WbSearch.ServiceWiring.php

@@ -10,7 +10,6 @@
 use Wikibase\Repo\Domains\Search\Application\UseCases\SimplePropertySearch\SimplePropertySearch;
 use Wikibase\Repo\Domains\Search\Application\Validation\SearchLanguageValidator;
 use Wikibase\Repo\Domains\Search\Infrastructure\DataAccess\InLabelSearchEngine;
-use Wikibase\Repo\Domains\Search\Infrastructure\DataAccess\SqlTermStoreSearchEngine;
 use Wikibase\Repo\RestApi\Middleware\MiddlewareHandler;
 use Wikibase\Repo\RestApi\Middleware\UnexpectedErrorHandlerMiddleware;
 
@@ -35,13 +34,6 @@ public static function getLanguageCodeValidator( ?ContainerInterface $services =
 		return ( $services ?: MediaWikiServices::getInstance() )->get( 'WbSearch.LanguageCodeValidator' );
 	}
 
-	/**
-	 * @return InLabelSearchEngine|SqlTermStoreSearchEngine
-	 */
-	public static function getSearchEngine( ?ContainerInterface $services = null ) {
-		return ( $services ?: MediaWikiServices::getInstance() )->get( 'WbSearch.SearchEngine' );
-	}
-
 	public static function getMiddlewareHandler( ?ContainerInterface $services = null ): MiddlewareHandler {
 		return ( $services ?: MediaWikiServices::getInstance() )->get( 'WbSearch.MiddlewareHandler' );
 	}