fix StatsFactory timing usage in EditEntity and View

 * remove deprecated use of copyToStatsdAt
 * remove deprecated use of TimingMetric->stop

TimingMetric->start() returns a RunningTimer instance that works
around the recursion use case (T368073)

Bug: T245464
Change-Id: I2f5c8bb4726359473ef91eeb4f2d00d2b6c999f7

Author: shdubsh

repo/includes/EditEntity/StatslibSaveTimeRecordingEditEntity.php

@@ -94,9 +94,7 @@ public function attemptSave(
 		$timing = $this->statsFactory
 			->getTiming( 'EditEntity_attemptSave_duration_seconds' )
 			->setLabel( 'type', $newEntity->getType() )
-			->copyToStatsdAt( "wikibase.repo.EditEntity.timing.EditEntity.attemptSave.{$newEntity->getType()}" );
-
-		$timing->start();
+			->start();
 		$result = $this->inner->attemptSave( $newEntity, $summary, $flags, $token, $watch, $tags );
 		$timing->stop();
 

repo/includes/EditEntity/StatslibSaveTimeRecordingEntityStore.php

@@ -49,9 +49,7 @@ public function saveEntity(
 		$timing = $this->statsFactory
 			->getTiming( 'EditEntity_EntityStore_saveEntity_duration_seconds' )
 			->setLabel( 'type', $entity->getType() )
-			->copyToStatsdAt( "wikibase.repo.EditEntity.timing.EntityStore.saveEntity.{$entity->getType()}" );
-
-		$timing->start();
+			->start();
 		$result = $this->entityStore->saveEntity( $entity, $summary, $user, $flags, $baseRevId, $tags );
 		$timing->stop();
 

view/src/FallbackChainModuleMethods.php

@@ -25,8 +25,7 @@ function () use ( $services ) {
 				$statsFactory = $services->getStatsFactory()->withComponent( 'WikibaseRepo' );
 				$timing = $statsFactory
 					->getTiming( 'fallbackchains_timing_seconds' )
-					->copyToStatsdAt( 'wikibase.view.fallbackchains.timing' );
-				$timing->start();
+					->start();
 
 				$fallbackChainFactory = WikibaseRepo::getLanguageFallbackChainFactory( $services );
 				$languages = WikibaseRepo::getTermsLanguages( $services )->getLanguages();