Use IGL's fast winding number, and control IGL threading #88
+15
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusCausemann
force-pushed
the
igl_fast_winding
branch
from
8af9377 to
dc552fb
Compare
added 2 commits
November 13, 2025 13:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGL has a wrapper for the fast winding number for soups, so we can use that instead of our own.
Additionally IGL has it's own threading, which is somewhat buggy, and can cause oversubscription and segfaults, see libigl/libigl#2412.
This PR sets the number of IGL threads to the square root of the specified number of threads, avoiding oversubscription due to nested parallel_for in igl::fast_winding_number.