Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing "Del" and confirming to kill process from the popup from the system tray icon crashes System Informer. #2336

Closed
Max33Verstappen opened this issue Dec 16, 2024 · 6 comments · Fixed by #2340
Closed

Pressing "Del" and confirming to kill process from the popup from the system tray icon crashes System Informer. #2336

Max33Verstappen opened this issue Dec 16, 2024 · 6 comments · Fixed by #2340

Comments

@Max33Verstappen
Copy link

"Double-clicking, Enter" on the popup from the system tray icon brings up the main window of System Informer and it crashes. Pressing "Del" (in the popup) asks you if want to terminate a process and when press "yes", it also crashes.
2024-12-16_10 06 20 277_explorer_Program_Manager
The last version that doesn't have this issue that I can download is "3.1.24244".
ge0rdi added a commit to ge0rdi/systeminformer that referenced this issue Dec 20, 2024
@ge0rdi
Fix user-after-free bug in miniinfo
81c5d0c 
Call to `PhPinMiniInformation` may result in hiding miniinfo window,
which will free its allocated resources and thus make `ProcessGroup`
invalid.

Fixes winsiderss#2278
Fixes winsiderss#2336
@ge0rdi ge0rdi mentioned this issue Dec 20, 2024
Merged
@ge0rdi
Copy link
Contributor

ge0rdi commented Dec 20, 2024

I think this is the same issue as #2278 (that was closed prematurely).

jxy-s added a commit that referenced this issue Jan 3, 2025
@ge0rdi @dmex @jxy-s
Fix user-after-free bug in miniinfo (#2340)
1aa795e 
Call to `PhPinMiniInformation` may result in hiding miniinfo window,
which will free its allocated resources and thus make `ProcessGroup`
invalid.

Fixes #2278
Fixes #2336

Co-authored-by: dmex <[email protected]>
Co-authored-by: Johnny Shaw <[email protected]>
@Max33Verstappen Max33Verstappen changed the title "Double clicking, Enter/Del" on the popup from the system tray icon crashes System Informer. Pressing "Del" and confirming to kill process from the popup from the system tray icon crashes System Informer. Jan 9, 2025
@Max33Verstappen
Copy link
Author

Max33Verstappen commented Jan 9, 2025 •
edited
Loading

I found that pressing "del" and then confirming to terminate the selected process still crashes System Informer.
395936697-0e88694b-c9c7-402c-96db-c2d7ec429501
Terminating processes using the context menu from the miniinfo window doesn't crash though.

@dmex
Copy link
Member

dmex commented Feb 13, 2025

Fixed in latest canary build

@dmex dmex closed this as completed Feb 13, 2025
@Max33Verstappen
Copy link
Author

Tried the latest "3.2.25051.101", but the crash still occurs.

@Max33Verstappen
Copy link
Author

Max33Verstappen commented Feb 24, 2025 •
edited
Loading

The crash occurs when I press the "Del" key with mouse OUTSIDE of the miniinfo window, as it would let the miniinfo disappear. Then pressing "Terminate" leads to the crash.

@dmex dmex reopened this Feb 25, 2025
dmex added a commit that referenced this issue Feb 25, 2025
@dmex
Fix miniinfo window crash after prompt #2336
e81671b
@Max33Verstappen
Copy link
Author

It's been fixed in the latest build. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix user-after-free bug in miniinfo ge0rdi/systeminformer
3 participants
@dmex @ge0rdi @Max33Verstappen