winter:version hangs and floods logs when the database is not initialized

[nmiyazaki-chapleau]

Winter CMS Build

1.2

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

Winter.Blocks, Winter.DriverAWS, Winter.DriverMailgun, Winter.Redirect, Winter.SEO, Winter.Sitemap, Winter.Translate, Winter.Pages

Issue description

Have been trying to deploy a Winter 1.2.6 website from dev to prod, but has been failing. I noticed the composer.json includes the post-update-cmd @php artisan winter:version. However, since the DB exists but is empty (no tables), the command just hangs and floods the logs with 23k line stack traces.
I can't start by doing a php artisan migrate since I can have relations to some Laravel package models which would not work if Laravel isn't installed, which means I have to start with composer install which, well, hangs and floods logs because of winter:version.

Steps to replicate

1. Git clone an already-configured website in WinterCMS 1.2.6
2. Configure your .env with valid db credentials
3. Run composer install

Workaround

Removing the winter:version command from the post-update-cmd section of the composer.json works.

[bennothommo]

@nmiyazaki-chapleau until we can investigate, you can always add the --no-scripts flag to composer install to skip the scripts.

[LukeTowers]

This bit me last week, will look into it next Wednesday during office hours.

[goldmont]

Hi,

When retrieving a Settings model before running migrations, an infinite loop occurs. The incriminated line is System\Behaviors\SettingsModel:136

$record = null;
try {
    $record = $query->first();
} catch (QueryException $ex) {
    // SQLSTATE[42S02]: Base table or view not found - migrations haven't run yet
    if ($ex->getCode() === '42S02') {
        traceLog($ex); // <-- This line generates an infinite loop
    }
}

In order to run php artisan winter:up, I have to comment that line.

[nmiyazaki-chapleau]

Hi,

When retrieving a Settings model before running migrations, an infinite loop occurs. The incriminated line is System\Behaviors\SettingsModel:136

$record = null;
try {
$record = $query->first();
} catch (QueryException $ex) {
// SQLSTATE[42S02]: Base table or view not found - migrations haven't run yet
if ($ex->getCode() === '42S02') {
traceLog($ex); // <-- This line generates an infinite loop
}
}

In order to run php artisan winter:up, I have to comment that line.

IIRC logs are also stored in the database to be able to see them in the backend, right? That would cause the infinite loop of trying to log an error and putting it in the database, which doesn't exist, which triggers an error, which tries logging it, etc.