Replace player/ents.GetAll with player/ents.Iterator (#3401)

* Replace player/ents.GetAll with player/ents.Iterator
These functions are now completely stable! Now it does not have any negative effects

* Fix

Author: Astralcircle

lua/entities/gmod_wire_expression2/core/extloader.lua

@@ -52,7 +52,7 @@ if ENT then
 		_Msg( "Calling constructors for all Expression 2 chips." )
 		wire_expression2_prepare_functiondata()
 		if not args or args[1] ~= "nosend" then
-			for _, p in ipairs( player.GetAll() ) do
+			for _, p in player.Iterator() do
 				if IsValid( p ) then wire_expression2_sendfunctions( p ) end
 			end
 		end

lua/entities/gmod_wire_expression2/core/hologram.lua

@@ -1571,7 +1571,7 @@ concommand.Add( "wire_holograms_block", function( ply, com, args )
 				clearholos_all(uid)
 			end
 			BlockList[v:SteamID()] = true
-			for _,p in ipairs( player.GetAll() ) do
+			for _,p in player.Iterator() do
 				p:PrintMessage( HUD_PRINTTALK, "(ADMIN) " .. v:GetName() .. " added to holograms blocklist" )
 			end
 		end
@@ -1598,7 +1598,7 @@ concommand.Add( "wire_holograms_unblock", function( ply, com, args )
 		local v = players[1]
 		if BlockList[v:SteamID()] == true then
 			BlockList[v:SteamID()] = nil
-			for _,player in ipairs( player.GetAll() ) do
+			for _,player in player.Iterator() do
 				player:PrintMessage( HUD_PRINTTALK, "(ADMIN) " .. v:GetName() .. " removed from holograms blocklist" )
 			end
 		else
@@ -1626,11 +1626,11 @@ concommand.Add( "wire_holograms_block_id", function( ply, com, args )
 		ConsoleMessage( ply, steamID .. " is already in the holograms blocklist!" )
 	else
 		BlockList[steamID] = true
-		for _,player in ipairs( player.GetAll() ) do
+		for _,player in player.Iterator() do
 			player:PrintMessage( HUD_PRINTTALK, "(ADMIN) " .. steamID .. " added to holograms blocklist" )
 		end
 		local uid
-		for _,v in ipairs( player.GetAll() ) do
+		for _,v in player.Iterator() do
 			if v:SteamID() == steamID then
 				uid = v:UniqueID()
 				if (E2HoloRepo[uid]) then
@@ -1655,7 +1655,7 @@ concommand.Add( "wire_holograms_unblock_id", function( ply, com, args )
 
 	if BlockList[steamID] == true then
 		BlockList[steamID] = nil
-		for _,player in ipairs( player.GetAll() ) do
+		for _,player in player.Iterator() do
 			player:PrintMessage( HUD_PRINTTALK, "(ADMIN) " .. steamID .. " removed from holograms blocklist" )
 		end
 	else

lua/entities/gmod_wire_expression2/core/player.lua

@@ -739,7 +739,7 @@ end
 e2function array playersAdmins()
 	local admins = {}
 
-	for _, ply in ipairs(player.GetAll()) do
+	for _, ply in player.Iterator() do
 		if ply:IsAdmin() then
 			table.insert(admins, ply)
 		end
@@ -751,7 +751,7 @@ end
 e2function array playersSuperAdmins()
 	local superadmins = {}
 
-	for _, ply in ipairs(player.GetAll()) do
+	for _, ply in player.Iterator() do
 		if ply:IsSuperAdmin() then
 			table.insert(superadmins, ply)
 		end

lua/entities/gmod_wire_graphics_tablet.lua

@@ -114,7 +114,7 @@ function ENT:Think()
 	local x = -w/2
 	local y = -h/2
 
-	for _,ply in pairs(player.GetAll()) do
+	for _,ply in player.Iterator() do
 		local trace = ply:GetEyeTraceNoCursor()
 		local ent = trace.Entity
 		if ent:IsValid() then

lua/entities/gmod_wire_hologram.lua

@@ -378,7 +378,7 @@ if CLIENT then
 		end,
 		function(cmd)
 			local help = {}
-			for _, ply in ipairs(player.GetAll()) do
+			for _, ply in player.Iterator() do
 				table.insert(help, cmd.." \""..ply:SteamID().."\" // "..ply:Name())
 			end
 			return help

lua/entities/gmod_wire_hudindicator/init.lua

@@ -288,7 +288,7 @@ function ENT:LinkEnt(pod)
 
 	local ply = nil
 	-- Check if a player is in pod first
-	for _, v in pairs(player.GetAll()) do
+	for _, v in player.Iterator() do
 		if (v:GetVehicle() == pod) then
 			ply = v
 			break
@@ -331,7 +331,7 @@ function ENT:Think()
 		local ply = nil
 
 		if not IsValid(self.PodPly) or self.PodPly:GetVehicle() ~= self.Pod then
-			for _, v in pairs(player.GetAll()) do
+			for _, v in player.Iterator() do
 				if (v:GetVehicle() == self.Pod) then
 					ply = v
 					break

lua/wire/flir.lua

@@ -111,7 +111,7 @@ end
 function FLIR.start()
 	if FLIR.enabled then return else FLIR.enabled = true end
 
-	for _, v in ipairs(ents.GetAll()) do
+	for _, v in ents.Iterator() do
 		SetFLIR(v)
 	end
 
@@ -190,7 +190,7 @@ function FLIR.stop()
 	hook.Remove("OnEntityCreated", "wire_flir")
 	hook.Remove("CreateClientsideRagdoll", "wire_flir")
 
-	for _, v in ipairs(ents.GetAll()) do
+	for _, v in ents.Iterator() do
 		RemoveFLIR(v)
 	end
 end

lua/wire/server/wirelib.lua

@@ -1581,13 +1581,13 @@ function WireLib.NotifyGroup(group, msg, severity, chatprint, color)
 	local plys = {}
 
 	if isstring(group) then
-		for _, p in ipairs(player.GetAll()) do
+		for _, p in player.Iterator() do
 			if p:GetUserGroup() == group then
 				plys[#plys + 1] = p
 			end
 		end
 	else
-		for _, p in ipairs(player.GetAll()) do
+		for _, p in player.Iterator() do
 			if table.HasValue(group, p:GetUserGroup()) then
 				plys[#plys + 1] = p
 			end

lua/wire/wire_paths.lua

@@ -101,7 +101,7 @@ function WireLib.Paths.Add(input, ply)
 	if ply then
 		table.insert(transmit_queues[ply], input)
 	else
-		for _, player in pairs(player.GetAll()) do
+		for _, player in player.Iterator() do
 			table.insert(transmit_queues[player], input)
 		end
 	end