Skip to content

Commit a12c42a

Browse files
Niels MöllerCommit Bot
Niels Möller
authored and
Commit Bot
committed
Delete root header file typedef.h.
Usage replaced with stdint.h, rtc_base/system/arch.h and rtc_base/system/unused.h, as appropriate. Bug: webrtc:6854 Change-Id: I97225465d14b969903d92979e2df3c3c05d35f18 Reviewed-on: https://webrtc-review.googlesource.com/90249 Reviewed-by: Niklas Enbom <[email protected]> Reviewed-by: Fredrik Solenberg <[email protected]> Commit-Queue: Niels Moller <[email protected]> Cr-Commit-Position: refs/heads/master@{#24100}
1 parent e41c433 commit a12c42a

File tree

435 files changed

+203
-540
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

435 files changed

+203
-540
lines changed

BUILD.gn

-11
Original file line numberDiff line numberDiff line change
@@ -384,22 +384,11 @@ if (!build_with_chromium) {
384384
}
385385
}
386386

387-
rtc_source_set("typedefs") {
388-
sources = [
389-
"typedefs.h",
390-
]
391-
deps = [
392-
"rtc_base/system:arch",
393-
"rtc_base/system:unused",
394-
]
395-
}
396-
397387
rtc_source_set("webrtc_common") {
398388
sources = [
399389
"common_types.h",
400390
]
401391
deps = [
402-
":typedefs",
403392
"api:array_view",
404393
"api/video:video_bitrate_allocation",
405394
"rtc_base:checks",

api/BUILD.gn

-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ rtc_static_library("libjingle_peerconnection_api") {
111111
# Basically, don't add stuff here. You might break sensitive downstream
112112
# targets like pnacl. API should not depend on anything outside of this
113113
# file, really. All these should arguably go away in time.
114-
"..:typedefs",
115114
"..:webrtc_common",
116115
"../logging:rtc_event_log_api",
117116
"../media:rtc_media_config",

api/audio/BUILD.gn

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ rtc_source_set("audio_frame_api") {
1616
]
1717

1818
deps = [
19-
"../../:typedefs",
2019
"../../rtc_base:checks",
2120
"../../rtc_base:rtc_base_approved",
2221
]

api/audio/audio_frame.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
#define API_AUDIO_AUDIO_FRAME_H_
1313

1414
#include <stddef.h>
15+
#include <stdint.h>
1516

1617
#include "rtc_base/constructormagic.h"
17-
#include "typedefs.h" // NOLINT(build/include)
1818

1919
namespace webrtc {
2020

api/audio_codecs/BUILD.gn

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ rtc_source_set("audio_codecs_api") {
3131
deps = [
3232
"..:array_view",
3333
"../..:webrtc_common",
34-
"../../:typedefs",
3534
"../../rtc_base:checks",
3635
"../../rtc_base:deprecation",
3736
"../../rtc_base:rtc_base_approved",

api/audio_codecs/audio_decoder.h

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include "api/array_view.h"
1919
#include "rtc_base/buffer.h"
2020
#include "rtc_base/constructormagic.h"
21-
#include "typedefs.h" // NOLINT(build/include)
2221

2322
namespace webrtc {
2423

api/audio_codecs/audio_encoder.h

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include "api/array_view.h"
2121
#include "rtc_base/buffer.h"
2222
#include "rtc_base/deprecation.h"
23-
#include "typedefs.h" // NOLINT(build/include)
2423

2524
namespace webrtc {
2625

api/rtp_headers.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include "common_types.h" // NOLINT(build/include)
2626
#include "rtc_base/checks.h"
2727
#include "rtc_base/deprecation.h"
28-
#include "typedefs.h" // NOLINT(build/include)
2928

3029
namespace webrtc {
3130

api/video/BUILD.gn

-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ rtc_source_set("video_bitrate_allocation") {
8484
"video_bitrate_allocation.h",
8585
]
8686
deps = [
87-
"../..:typedefs",
8887
"../../rtc_base:checks",
8988
"../../rtc_base:safe_conversions",
9089
"../../rtc_base:stringutils",

api/video/video_bitrate_allocation.h

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include <vector>
1717

1818
#include "absl/types/optional.h"
19-
#include "typedefs.h" // NOLINT(build/include)
2019

2120
namespace webrtc {
2221

audio/utility/BUILD.gn

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ rtc_static_library("audio_frame_operations") {
2222

2323
deps = [
2424
"../..:webrtc_common",
25-
"../../:typedefs",
2625
"../../api/audio:audio_frame_api",
2726
"../../rtc_base:checks",
2827
"../../rtc_base:rtc_base_approved",

audio/utility/audio_frame_operations.h

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include <stddef.h>
1515

1616
#include "api/audio/audio_frame.h"
17-
#include "typedefs.h" // NOLINT(build/include)
1817

1918
namespace webrtc {
2019

call/BUILD.gn

-3
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ rtc_source_set("call_interfaces") {
3030
":rtp_interfaces",
3131
":video_stream_api",
3232
"..:webrtc_common",
33-
"../:typedefs",
3433
"../api:fec_controller_api",
3534
"../api:libjingle_peerconnection_api",
3635
"../api:transport_api",
@@ -236,7 +235,6 @@ rtc_source_set("video_stream_api") {
236235
]
237236
deps = [
238237
":rtp_interfaces",
239-
"../:typedefs",
240238
"../:webrtc_common",
241239
"../api:libjingle_peerconnection_api",
242240
"../api:transport_api",
@@ -258,7 +256,6 @@ rtc_source_set("fake_network") {
258256
]
259257
deps = [
260258
":call_interfaces",
261-
"..:typedefs",
262259
"..:webrtc_common",
263260
"../api:simulated_network_api",
264261
"../api:transport_api",

call/audio_receive_stream.h

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "call/rtp_config.h"
2525
#include "common_types.h" // NOLINT(build/include)
2626
#include "rtc_base/scoped_ref_ptr.h"
27-
#include "typedefs.h" // NOLINT(build/include)
2827

2928
namespace webrtc {
3029
class AudioSinkInterface;

call/audio_send_stream.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include "call/rtp_config.h"
2626
#include "modules/audio_processing/include/audio_processing_statistics.h"
2727
#include "rtc_base/scoped_ref_ptr.h"
28-
#include "typedefs.h" // NOLINT(build/include)
2928

3029
namespace webrtc {
3130

call/fake_network_pipe.h

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include "rtc_base/criticalsection.h"
2929
#include "rtc_base/random.h"
3030
#include "rtc_base/thread_annotations.h"
31-
#include "typedefs.h" // NOLINT(build/include)
3231

3332
namespace webrtc {
3433

common_audio/BUILD.gn

+6-5
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ rtc_static_library("common_audio") {
5555
":fft4g",
5656
":sinc_resampler",
5757
"..:webrtc_common",
58-
"../:typedefs",
5958
"../rtc_base:checks",
6059
"../rtc_base:gtest_prod",
6160
"../rtc_base:rtc_base_approved",
6261
"../rtc_base/memory:aligned_array",
6362
"../rtc_base/memory:aligned_malloc",
63+
"../rtc_base/system:arch",
6464
"../system_wrappers",
6565
"../system_wrappers:cpu_features_api",
6666
"//third_party/abseil-cpp/absl/types:optional",
@@ -192,11 +192,11 @@ rtc_source_set("common_audio_c") {
192192
":common_audio_cc",
193193
":fft4g",
194194
"..:webrtc_common",
195-
"../:typedefs",
196195
"../rtc_base:checks",
197196
"../rtc_base:compile_assert_c",
198197
"../rtc_base:rtc_base_approved",
199198
"../rtc_base:sanitizer",
199+
"../rtc_base/system:arch",
200200
"../system_wrappers",
201201
"../system_wrappers:cpu_features_api",
202202
]
@@ -218,7 +218,6 @@ rtc_source_set("common_audio_cc") {
218218

219219
deps = [
220220
"..:webrtc_common",
221-
"../:typedefs",
222221
"../rtc_base:rtc_base_approved",
223222
"../system_wrappers",
224223
]
@@ -230,10 +229,10 @@ rtc_source_set("sinc_resampler") {
230229
]
231230
deps = [
232231
"..:webrtc_common",
233-
"../:typedefs",
234232
"../rtc_base:gtest_prod",
235233
"../rtc_base:rtc_base_approved",
236234
"../rtc_base/memory:aligned_malloc",
235+
"../rtc_base/system:arch",
237236
"../system_wrappers",
238237
]
239238
}
@@ -257,6 +256,7 @@ rtc_source_set("fir_filter_factory") {
257256
":fir_filter",
258257
"../rtc_base:checks",
259258
"../rtc_base:rtc_base_approved",
259+
"../rtc_base/system:arch",
260260
"../system_wrappers:cpu_features_api",
261261
]
262262
if (current_cpu == "x86" || current_cpu == "x64") {
@@ -353,6 +353,7 @@ if (rtc_build_with_neon) {
353353
":common_audio_c",
354354
"../rtc_base:checks",
355355
"../rtc_base:rtc_base_approved",
356+
"../rtc_base/system:arch",
356357
]
357358
}
358359
}
@@ -404,10 +405,10 @@ if (rtc_include_tests) {
404405
":fir_filter_factory",
405406
":sinc_resampler",
406407
"..:webrtc_common",
407-
"../:typedefs",
408408
"../rtc_base:checks",
409409
"../rtc_base:rtc_base_approved",
410410
"../rtc_base:rtc_base_tests_utils",
411+
"../rtc_base/system:arch",
411412
"../system_wrappers:cpu_features_api",
412413
"../test:fileutils",
413414
"../test:test_main",

common_audio/audio_util.cc

-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
#include "common_audio/include/audio_util.h"
1212

13-
#include "typedefs.h" // NOLINT(build/include)
14-
1513
namespace webrtc {
1614

1715
void FloatToS16(const float* src, size_t size, int16_t* dest) {

common_audio/audio_util_unittest.cc

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "rtc_base/arraysize.h"
1414
#include "test/gmock.h"
1515
#include "test/gtest.h"
16-
#include "typedefs.h" // NOLINT(build/include)
1716

1817
namespace webrtc {
1918
namespace {

common_audio/fir_filter_factory.cc

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
#include "common_audio/fir_filter_c.h"
1414
#include "rtc_base/checks.h"
15+
#include "rtc_base/system/arch.h"
1516
#include "system_wrappers/include/cpu_features_wrapper.h"
1617

1718
#if defined(WEBRTC_HAS_NEON)

common_audio/include/audio_util.h

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
#include <limits>
1818

1919
#include "rtc_base/checks.h"
20-
#include "typedefs.h" // NOLINT(build/include)
2120

2221
namespace webrtc {
2322

common_audio/resampler/include/push_resampler.h

-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313

1414
#include <memory>
1515

16-
#include "typedefs.h" // NOLINT(build/include)
17-
1816
namespace webrtc {
1917

2018
class PushSincResampler;

common_audio/resampler/include/resampler.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
#define COMMON_AUDIO_RESAMPLER_INCLUDE_RESAMPLER_H_
1717

1818
#include <stddef.h>
19-
20-
#include "typedefs.h" // NOLINT(build/include)
19+
#include <stdint.h>
2120

2221
namespace webrtc {
2322

common_audio/resampler/push_sinc_resampler.h

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
#include "common_audio/resampler/sinc_resampler.h"
1717
#include "rtc_base/constructormagic.h"
18-
#include "typedefs.h" // NOLINT(build/include)
1918

2019
namespace webrtc {
2120

common_audio/resampler/push_sinc_resampler_unittest.cc

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "rtc_base/timeutils.h"
2020
#include "test/gmock.h"
2121
#include "test/gtest.h"
22-
#include "typedefs.h" // NOLINT(build/include)
2322

2423
namespace webrtc {
2524
namespace {

common_audio/resampler/sinc_resampler.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@
9393
#include <limits>
9494

9595
#include "rtc_base/checks.h"
96+
#include "rtc_base/system/arch.h"
9697
#include "system_wrappers/include/cpu_features_wrapper.h"
97-
#include "typedefs.h" // NOLINT(build/include)
9898

9999
namespace webrtc {
100100

common_audio/resampler/sinc_resampler.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include "rtc_base/constructormagic.h"
2020
#include "rtc_base/gtest_prod_util.h"
2121
#include "rtc_base/memory/aligned_malloc.h"
22-
#include "typedefs.h" // NOLINT(build/include)
22+
#include "rtc_base/system/arch.h"
2323

2424
namespace webrtc {
2525

common_audio/resampler/sinc_resampler_unittest.cc

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "common_audio/resampler/sinc_resampler.h"
2424
#include "common_audio/resampler/sinusoidal_linear_chirp_source.h"
2525
#include "rtc_base/stringize_macros.h"
26+
#include "rtc_base/system/arch.h"
2627
#include "rtc_base/timeutils.h"
2728
#include "system_wrappers/include/cpu_features_wrapper.h"
2829
#include "test/gmock.h"

common_audio/signal_processing/complex_fft.c

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
#include "common_audio/signal_processing/complex_fft_tables.h"
1919
#include "common_audio/signal_processing/include/signal_processing_library.h"
20+
#include "rtc_base/system/arch.h"
2021

2122
#define CFFTSFT 14
2223
#define CFFTRND 1

common_audio/signal_processing/complex_fft_tables.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#ifndef COMMON_AUDIO_SIGNAL_PROCESSING_COMPLEX_FFT_TABLES_H_
1212
#define COMMON_AUDIO_SIGNAL_PROCESSING_COMPLEX_FFT_TABLES_H_
1313

14-
#include "typedefs.h" // NOLINT(build/include)
14+
#include <stdint.h>
1515

1616
static const int16_t kSinTable1024[] = {
1717
0, 201, 402, 603, 804, 1005, 1206, 1406, 1607,

common_audio/signal_processing/cross_correlation_neon.c

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
*/
1010

1111
#include "common_audio/signal_processing/include/signal_processing_library.h"
12+
#include "rtc_base/system/arch.h"
1213

1314
#include <arm_neon.h>
1415

common_audio/signal_processing/dot_product_with_scale.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@
1111
#ifndef COMMON_AUDIO_SIGNAL_PROCESSING_DOT_PRODUCT_WITH_SCALE_H_
1212
#define COMMON_AUDIO_SIGNAL_PROCESSING_DOT_PRODUCT_WITH_SCALE_H_
1313

14+
#include <stdint.h>
1415
#include <string.h>
1516

16-
#include "typedefs.h" // NOLINT(build/include)
17-
1817
#ifdef __cplusplus
1918
extern "C" {
2019
#endif

common_audio/signal_processing/include/real_fft.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#ifndef COMMON_AUDIO_SIGNAL_PROCESSING_INCLUDE_REAL_FFT_H_
1212
#define COMMON_AUDIO_SIGNAL_PROCESSING_INCLUDE_REAL_FFT_H_
1313

14-
#include "typedefs.h" // NOLINT(build/include)
14+
#include <stdint.h>
1515

1616
// For ComplexFFT(), the maximum fft order is 10;
1717
// WebRTC APM uses orders of only 7 and 8.

common_audio/signal_processing/include/signal_processing_library.h

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
#include <string.h>
2121
#include "common_audio/signal_processing/dot_product_with_scale.h"
22-
#include "typedefs.h" // NOLINT(build/include)
2322

2423
// Macros specific for the fixed point implementation
2524
#define WEBRTC_SPL_WORD16_MAX 32767

common_audio/signal_processing/real_fft_unittest.cc

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include "common_audio/signal_processing/include/real_fft.h"
1212
#include "common_audio/signal_processing/include/signal_processing_library.h"
1313
#include "test/gtest.h"
14-
#include "typedefs.h" // NOLINT(build/include)
1514

1615
namespace webrtc {
1716
namespace {

0 commit comments

Comments
 (0)