feat!: remove $$result.createAstro() first arg (#1112)

florian-lefebvre · web-flow · commit bd5be73731d1 · 2025-09-29T17:35:39.000+02:00
diff --git a/.changeset/little-spoons-search.md b/.changeset/little-spoons-search.md
@@ -0,0 +1,12 @@
+---
+"@astrojs/compiler": major
+---
+
+Removes the first argument of `$$result.createAstro()`
+
+`$$result.createAstro()` does not accept an `AstroGlobalPartial` as the first argument anymore:
+
+```diff
+-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
++const Astro = $$result.createAstro($$props, $$slots);
+```
diff --git a/.changeset/pre.json b/.changeset/pre.json
diff --git a/internal/printer/__printer_js__/React_framework_example.snap b/internal/printer/__printer_js__/React_framework_example.snap
@@ -83,7 +83,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [{ module
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 // Component Imports
diff --git a/internal/printer/__printer_js__/Use_of_interfaces_within_frontmatter.snap b/internal/printer/__printer_js__/Use_of_interfaces_within_frontmatter.snap
@@ -43,7 +43,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 interface MarkdownFrontmatter {
diff --git a/internal/printer/__printer_js__/class_list_with_spread.snap b/internal/printer/__printer_js__/class_list_with_spread.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$maybeRenderHead($$result)}<div class:list="something"${$$spreadAttributes(Astro.props)}></div>`;
diff --git a/internal/printer/__printer_js__/class_with_spread.snap b/internal/printer/__printer_js__/class_with_spread.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$maybeRenderHead($$result)}<div class="something"${$$spreadAttributes(Astro.props)}></div>`;
diff --git a/internal/printer/__printer_js__/complex_recursive_component.snap b/internal/printer/__printer_js__/complex_recursive_component.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata("/projects/app/src/components/RenderN
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$RenderNode = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$RenderNode;
 
 return $$render`${($$render`${$$renderComponent($$result,'Fragment',Fragment,{},{"default": () => $$render`${$$renderComponent($$result,'Fragment',Fragment,{},{"default": () => $$render`${$$unescapeHTML(`<${Node.tag} ${stringifyAttributes(Node.attributes)}>`)}`,})}${Node.children.map((child) => ($$render`${$$renderComponent($$result,'Astro.self',Astro.self,{"node":(child)})}`))}${$$renderComponent($$result,'Fragment',Fragment,{},{"default": () => $$render`${$$unescapeHTML(`</${Node.tag}>`)}`,})}`,})}`)}`;
diff --git a/internal/printer/__printer_js__/complex_table.snap b/internal/printer/__printer_js__/complex_table.snap
@@ -78,7 +78,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`<html lang="en">
diff --git a/internal/printer/__printer_js__/dynamic_import.snap b/internal/printer/__printer_js__/dynamic_import.snap
@@ -39,7 +39,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(async ($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 const markdownDocs = await Astro.glob('../markdown/*.md')
diff --git a/internal/printer/__printer_js__/expression_returning_multiple_elements.snap b/internal/printer/__printer_js__/expression_returning_multiple_elements.snap
@@ -57,7 +57,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$renderComponent($$result,'Layout',Layout,{"title":"Welcome to Astro."},{"default": () => $$render`
diff --git a/internal/printer/__printer_js__/function_expression_slots_II___959_.snap b/internal/printer/__printer_js__/function_expression_slots_II___959_.snap
@@ -48,7 +48,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$renderComponent($$result,'Layout',Layout,{"title":"Welcome to Astro."},{"default": () => $$render`
diff --git a/internal/printer/__printer_js__/import.meta.env.snap b/internal/printer/__printer_js__/import.meta.env.snap
@@ -100,7 +100,7 @@ export async function getStaticPaths() {
   });
 }
 const $$Component = $$createComponent(async ($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 const { product } = Astro.props;
diff --git a/internal/printer/__printer_js__/nested_expressions.snap b/internal/printer/__printer_js__/nested_expressions.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$maybeRenderHead($$result)}<article>${(previous || next) && $$render`<aside>${previous && $$render`<div>Previous Article: <a rel="prev"${$$addAttribute(new URL(previous.link, Astro.site).pathname, "href")}>${previous.text}</a></div>`}${next && $$render`<div>Next Article: <a rel="next"${$$addAttribute(new URL(next.link, Astro.site).pathname, "href")}>${next.text}</a></div>`}</aside>`}</article>`;
diff --git a/internal/printer/__printer_js__/nested_expressions_II.snap b/internal/printer/__printer_js__/nested_expressions_II.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$maybeRenderHead($$result)}<article>${(previous || next) && $$render`<aside>${previous && $$render`<div>Previous Article: <a rel="prev"${$$addAttribute(new URL(previous.link, Astro.site).pathname, "href")}>${previous.text}</a></div>`} ${next && $$render`<div>Next Article: <a rel="next"${$$addAttribute(new URL(next.link, Astro.site).pathname, "href")}>${next.text}</a></div>`}</aside>`}</article>`;
diff --git a/internal/printer/__printer_js__/spread_with_style_but_no_explicit_class.snap b/internal/printer/__printer_js__/spread_with_style_but_no_explicit_class.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$maybeRenderHead($$result)}<div${$$spreadAttributes(Astro.props,undefined,{"class":"astro-XXXX"})}></div>`;
diff --git a/internal/printer/__printer_js__/spread_without_style_or_class.snap b/internal/printer/__printer_js__/spread_without_style_or_class.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${$$maybeRenderHead($$result)}<div${$$spreadAttributes(Astro.props)}></div>`;
diff --git a/internal/printer/__printer_js__/table_with_expression_in__th_.snap b/internal/printer/__printer_js__/table_with_expression_in__th_.snap
@@ -80,7 +80,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 const { title, footnotes, tables } = Astro.props;
diff --git a/internal/printer/__printer_js__/ternary_layout.snap b/internal/printer/__printer_js__/ternary_layout.snap
@@ -35,7 +35,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Astro = $$createAstro('https://astro.build');
 const Astro = $$Astro;
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
-const Astro = $$result.createAstro($$Astro, $$props, $$slots);
+const Astro = $$result.createAstro($$props, $$slots);
 Astro.self = $$Component;
 
 return $$render`${toggleError ? $$render`${$$renderComponent($$result,'BaseLayout',BaseLayout,{},{"default": () => $$render`${$$maybeRenderHead($$result)}<h1>SITE: ${Astro.site}</h1>`,})}` : $$render`${$$renderComponent($$result,'Fragment',Fragment,{},{"default": () => $$render`<h1>SITE: ${Astro.site}</h1>`,})}`}`;
diff --git a/internal/printer/printer.go b/internal/printer/printer.go
@@ -349,7 +349,7 @@ func (p *printer) printFuncPrelude(opts transform.TransformOptions, printAstroGl
 	p.println(fmt.Sprintf("const %s = %s(%s(%s, $$props, %s) => {", componentName, CREATE_COMPONENT, p.getAsyncFuncPrefix(), RESULT, SLOTS))
 	if printAstroGlobal {
 		p.addNilSourceMapping()
-		p.println(fmt.Sprintf("const Astro = %s.createAstro($$Astro, $$props, %s);", RESULT, SLOTS))
+		p.println(fmt.Sprintf("const Astro = %s.createAstro($$props, %s);", RESULT, SLOTS))
 		p.addNilSourceMapping()
 		p.println(fmt.Sprintf("Astro.self = %s;", componentName))
 	}
diff --git a/internal/printer/printer_test.go b/internal/printer/printer_test.go
@@ -34,7 +34,7 @@ var INTERNAL_IMPORTS = fmt.Sprintf("import {\n  %s\n} from \"%s\";\n", strings.J
 }, ",\n  "), "http://localhost:3000/")
 var PRELUDE = fmt.Sprintf(`const $$Component = %s(($$result, $$props, %s) => {`, CREATE_COMPONENT, SLOTS)
 var PRELUDE_WITH_ASYNC = fmt.Sprintf(`const $$Component = %s(async ($$result, $$props, %s) => {`, CREATE_COMPONENT, SLOTS)
-var PRELUDE_ASTRO_GLOBAL = fmt.Sprintf(`const Astro = $$result.createAstro($$Astro, $$props, %s);
+var PRELUDE_ASTRO_GLOBAL = fmt.Sprintf(`const Astro = $$result.createAstro($$props, %s);
 Astro.self = $$Component;`, SLOTS)
 var RETURN = fmt.Sprintf("return %s%s", TEMPLATE_TAG, BACKTICK)
 var SUFFIX = fmt.Sprintf("%s;", BACKTICK) + `
