Merge branch 'main' into stack/invalid-canonical

Author: delucis

.changeset/kind-mirrors-kneel.md

@@ -0,0 +1,5 @@
+---
+"@astrojs/starlight": patch
+---
+
+Updates the `seti:gitlab` icon to match latest version from Seti UI Icons

.changeset/wild-poets-poke.md

@@ -23,16 +23,32 @@ jobs:
       pull-requests: read
     outputs:
       docs: ${{ steps.filter.outputs.docs }}
+      docs_ja: ${{ steps.filter.outputs.docs_ja }}
+      docs_en: ${{ steps.filter.outputs.docs_en }}
+      docs_not_content: ${{ steps.filter.outputs.docs_not_content }}
       packages: ${{ steps.filter.outputs.packages }}
       ci: ${{ steps.filter.outputs.ci }}
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: filter
+        # When updating filters here, make sure to also add or remove them from the
+        # outputs block above.
         with:
           filters: |
             docs:
               - 'docs/**'
+            docs_ja:
+              - 'docs/src/content/docs/ja/**'
+            docs_en:
+              - 'docs/src/content/docs/**'
+              # Exclude languages with a two-letter code
+              - '!docs/src/content/docs/{a..z}{a..z}/**'
+              # Exclude languages with a region subtag
+              - '!docs/src/content/docs/{a..z}{a..z}-{a..z}{a..z}/**'
+            docs_not_content:
+              - 'docs/**'
+              - '!docs/src/content/docs/**'
             packages:
               - 'packages/**'
             ci:
@@ -68,14 +84,30 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      # Uninstall man-db to prevent man page updates taking a long time after package installations
+      # on Ubuntu 24.04.
+      # https://github.com/actions/runner/issues/4030
+      # https://github.com/actions/runner-images/issues/10977
+      - name: Uninstall man-db
+        if: matrix.os == 'ubuntu-latest'
+        run: |
+          sudo apt-get update
+          sudo apt-get remove man-db
       - uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
       - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: 'pnpm'
       - run: pnpm i
-      - name: Test packages
-        run: pnpm -r test:e2e
+      - name: Test packages (Linux)
+        if: matrix.os == 'ubuntu-latest'
+        run: pnpm -r test:e2e:chrome
+      # Firefox is used for Windows E2E tests as Chrome on Windows requires the installation of the
+      # Server Media Foundation windows feature, which can take up to 3 minutes to install on CI.
+      # https://github.com/microsoft/playwright/blob/e7bff526433b6dcb02801763ab5b1c6407902d47/packages/playwright-core/src/server/registry/dependencies.ts#L79-L89
+      - name: Test packages (Windows)
+        if: matrix.os == 'windows-latest'
+        run: pnpm -r test:e2e:firefox
 
   type-check:
     name: Run type checks
@@ -113,11 +145,22 @@ jobs:
 
   a11y:
     name: Check for accessibility issues
+    needs: changes
+    if: ${{ needs.changes.outputs.docs_not_content == 'true' || needs.changes.outputs.docs_ja == 'true' || needs.changes.outputs.docs_en == 'true' || needs.changes.outputs.ci == 'true' || needs.changes.outputs.packages == 'true' }}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
+      # Uninstall man-db to prevent man page updates taking a long time after package installations
+      # on Ubuntu 24.04.
+      # https://github.com/actions/runner/issues/4030
+      # https://github.com/actions/runner-images/issues/10977
+      - name: Uninstall man-db
+        run: |
+          sudo apt-get update
+          sudo apt-get remove man-db
+
       - name: Setup PNPM
         uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
 

.github/workflows/ci.yml

@@ -1,4 +1,5 @@
 name: Release
+permissions: {}
 
 on:
   push:
@@ -12,21 +13,23 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: write
+      pull-requests: write
       id-token: write
     steps:
       - name: Checkout Repo
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
+          persist-credentials: false
 
       - name: Setup PNPM
         uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
 
       - name: Setup Node
         uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
         with:
-          node-version: 18.20.8
+          node-version: 24.10.0
           cache: 'pnpm'
 
       - name: Install Dependencies
@@ -41,4 +44,4 @@ jobs:
           title: '[ci] release'
         env:
           GITHUB_TOKEN: ${{ secrets.FREDKBOT_GITHUB_TOKEN }}
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NPM_TOKEN: "" # See https://github.com/changesets/changesets/issues/1152#issuecomment-3190884868

.github/workflows/release.yml

@@ -25,3 +25,6 @@ packages/starlight/__e2e__/fixtures/basics/src/content/docs/anchor-heading-compo
 
 # Malformed YAML file used for testing
 packages/starlight/__tests__/i18n/malformed-yaml-src/content/i18n/*.yml
+
+# GitHub Actions workflow files
+.github/workflows/*.yml

.prettierignore

@@ -38,7 +38,7 @@ This repo is a “monorepo,” meaning it contains several projects in one. It c
 
 ### Setting up a development environment
 
-You can [develop locally](#developing-locally) or use an online coding development environment like [GitHub Codespaces](#developing-using-github-codespaces) or [Gitpod](#developing-using-gitpod) to get started quickly.
+You can [develop locally](#developing-locally) or use an online coding development environment like [GitHub Codespaces](#developing-using-github-codespaces) to get started quickly.
 
 #### Developing locally
 
@@ -64,23 +64,24 @@ You can [develop locally](#developing-locally) or use an online coding developme
    pnpm i
    ```
 
-#### Developing using Gitpod
-
-**Prerequisites:** Developing Starlight using Gitpod requires a free [Gitpod account](https://gitpod.io).
-
-1. **Open the Gitpod URL** [https://gitpod.io/#https://github.com/withastro/starlight](https://gitpod.io/#https://github.com/withastro/starlight). You can alternatively install a [Gitpod browser extension](https://www.gitpod.io/docs/configure/user-settings/browser-extension) which will add a "Gitpod" button when viewing [Starlight's repo on GitHub](https://github.com/withastro/starlight).
-
-2. **Install dependencies** with `pnpm`:
+5. **Generate TypeScript types** for all Astro modules:
 
    ```sh
-   pnpm i
+   cd docs
+   pnpm astro sync
    ```
 
 #### Developing using GitHub Codespaces
 
 1. **Create a new codespace** via https://codespaces.new/withastro/starlight
 
-2. If running the docs site, pass the `--host` flag to avoid “502 Bad Gateway” errors:
+2. **Generate TypeScript types** for all Astro modules:
+
+   ```sh
+   pnpm astro sync
+   ```
+
+3. If running the docs site, pass the `--host` flag to avoid “502 Bad Gateway” errors:
 
    ```sh
    cd docs

CONTRIBUTING.md

@@ -7,6 +7,10 @@ import {
 } from 'axe-playwright';
 import Sitemapper from 'sitemapper';
 
+// We use the Lunaria config to get the list of languages rather than the Astro config as importing
+// the latter does not play well with Playwright.
+import lunariaConfig from '../lunaria.config.json' assert { type: 'json' };
+
 export { expect, type Locator } from '@playwright/test';
 
 const config: Config = {
@@ -17,29 +21,37 @@ const config: Config = {
 			values: ['wcag2a', 'wcag21a', 'wcag2aa', 'wcag21aa', 'wcag22aa', 'best-practice'],
 		},
 	},
+	// i18n specific configuration.
+	i18n: {
+		// A list of slugs to exclude from the sitemap for the default locale.
+		// By default, all slugs for the default locale are included.
+		exclude: [
+			'components/using-components',
+			'getting-started',
+			'guides/customization',
+			'guides/i18n',
+			'guides/overriding-components',
+			'guides/pages',
+			'guides/project-structure',
+			'guides/route-data',
+			'guides/site-search',
+			'manual-setup',
+			'reference/frontmatter',
+			'reference/overrides',
+			'reference/plugins',
+			'reference/route-data',
+		],
+		// Locale-specific included slugs (non-default locale slugs are excluded by default).
+		locales: {
+			// N.B. If adding more locales here, also update the changed files filters in
+			// `.github/workflows/ci.yml` to ensure tests run when files for those locales change.
+			ja: ['guides/route-data', 'reference/frontmatter'],
+		},
+	},
 	// A list of violation to ignore.
 	ignore: [{ id: 'landmark-unique', nodeMatcher: landmarkUniqueNodeMatcher }],
 	sitemap: {
 		url: 'http://localhost:4321/sitemap-index.xml',
-		exclude: {
-			// A pattern to exclude URLs from the sitemap.
-			pattern: /\/(de|zh-cn|fr|es|pt-br|pt-pt|it|id|ko|ru|tr|hi|da|uk)\/.*/,
-			// A list of slugs to exclude from the sitemap after processing the pattern.
-			slugs: [
-				'components/using-components',
-				'getting-started',
-				'guides/customization',
-				'guides/i18n',
-				'guides/overriding-components',
-				'guides/pages',
-				'guides/project-structure',
-				'guides/site-search',
-				'manual-setup',
-				'reference/frontmatter',
-				'reference/overrides',
-				'reference/plugins',
-			],
-		},
 		replace: {
 			query: 'https://starlight.astro.build',
 			value: 'http://localhost:4321',
@@ -50,6 +62,8 @@ const config: Config = {
 process.env.ASTRO_TELEMETRY_DISABLED = 'true';
 process.env.ASTRO_DISABLE_UPDATE_CHECK = 'true';
 
+const locales = lunariaConfig.locales.map((locale) => locale.lang);
+
 export const test = baseTest.extend<{
 	docsSite: DocsSite;
 }>({
@@ -71,9 +85,24 @@ class DocsSite {
 		const urls: string[] = [];
 
 		for (const site of sites) {
-			const url = site.replace(config.sitemap.replace.query, config.sitemap.replace.value);
-			if (config.sitemap.exclude.pattern.test(url)) continue;
-			if (config.sitemap.exclude.slugs.some((slug) => url.endsWith(`/${slug}/`))) continue;
+			const slug = site.replace(config.sitemap.replace.query, '');
+			const url = config.sitemap.replace.value + slug;
+
+			// Default locale
+			if (!locales.some((locale) => slug.startsWith(`/${locale}/`))) {
+				// Skip default locale excluded slugs
+				if (config.i18n.exclude.some((excludedSlug) => slug.endsWith(`/${excludedSlug}/`)))
+					continue;
+			} else {
+				// Get locale-specific config
+				const locale = slug.split('/')[1]!;
+				const localeConfig = config.i18n.locales[locale];
+				// Skip non-configured locales
+				if (!localeConfig) continue;
+				// Skip locale-specific non-included slugs
+				if (!localeConfig.some((includedSlug) => slug.endsWith(`/${includedSlug}/`))) continue;
+			}
+
 			urls.push(url);
 		}
 
@@ -129,6 +158,7 @@ function landmarkUniqueNodeMatcher(node: ViolationNode) {
 
 interface Config {
 	axe: Parameters<typeof getViolations>[2];
+	i18n: { exclude: string[]; locales: Record<string, string[]> };
 	ignore: Array<
 		| string
 		| {
@@ -140,10 +170,6 @@ interface Config {
 	>;
 	sitemap: {
 		url: string;
-		exclude: {
-			pattern: RegExp;
-			slugs: string[];
-		};
 		replace: {
 			query: string;
 			value: string;