Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract runtime APIs from AppHost #2

Open
felixb-wix opened this issue Mar 24, 2019 · 1 comment
Open

Extract runtime APIs from AppHost #2

felixb-wix opened this issue Mar 24, 2019 · 1 comment
Labels
backlog This issue belongs to backlog enhancement New feature or request public-api This issue shapes the public API of the library

Comments

@felixb-wix
Copy link
Contributor

AppHost contains many utility/administration functions. These functions can be extracted into APIs. They will be treated as any other API, and stop being special cases.

Below is proposed API names and contents.

AppHostDebugAPI

  • getAllSlotKeys(): AnySlotKey[]
  • getAllFeatures(): FeatureInfo[]

AppHostAdminAPI

  • isFeatureInstalled(name: string): boolean
  • isLazyFeature(name: string): boolean
  • installFeatures(features: AnyFeature[]): void
  • uninstallFeatures(names: string[]): void
@felixb-wix felixb-wix added enhancement New feature or request backlog This issue belongs to backlog public-api This issue shapes the public API of the library labels Mar 24, 2019
@felixb-wix
Copy link
Contributor Author

Here cfc516b I did first steps:

  • create AppHostServices entry point
  • create AppHostAPI (currently empty), which is contributed by AppHostServices entry point

Next step, the functions from AppHost need to be moved to AppHostAPI. Distinction between Admin and Debug API seems to be unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This issue belongs to backlog enhancement New feature or request public-api This issue shapes the public API of the library
Projects
None yet
Development

No branches or pull requests

1 participant