Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append New Tabs #7

Open
Shadow6363 opened this issue Mar 18, 2014 · 3 comments
Open

Append New Tabs #7

Shadow6363 opened this issue Mar 18, 2014 · 3 comments

Comments

@Shadow6363
Copy link

In the previous new tab page, if I ctrl/cmd + clicked on one of my frequently visited links, it would append the new tab to the end of my open tabs, i.e. it would show up as my last tab. With the new new tab page, it prepends the new tab i.e. it shows up as the first tab after any pinned tabs. Is there any way to restore the previous behavior? Perhaps make it toggleable if so in case people prefer the new way.

Edit/Note: I know the Chrome extension API supports specifying the index where a new tab will be created so it should be possible.

@wjywbs
Copy link
Owner

wjywbs commented Mar 18, 2014

I tried this just now in my browser, and it opens a link next to this new tab page on the right. I think if you place the new tab page as the last tab, it should create a tab as the last. I don't know why your browser behaves differently.

I can think about adding an option.

@Shadow6363
Copy link
Author

That's how it's working for me as well. I suppose I should have mentioned that I have a copy of the new tab page pinned. Cmd/Ctrl + clicking one of the links from that would previously open it as the last tab whereas now it opens it as the first unpinned tab. I could unpin it and move it to the end and it would then open them at the end; however, I have so many tabs open I like to keep one of the new tab pages pinned.

Anyway, I wrote up a quick patch which fixes the problem for me. I may pull request it if you think it's worthwhile. Thanks for your work on bringing us the original page back. Works well!

@wjywbs
Copy link
Owner

wjywbs commented Mar 19, 2014

Can you please share your changes? I'm wondering how to detect Ctrl+click. I will try the previous new tab page in chrome 32. If this is the same behavior in previous ntp, I would like to add this feature as default. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants