Enable MediaWiki.Arrays.TrailingComma sniff

Enforce trailing commas in multi-line arrays, and no trailing commas in
single-line arrays.

In one line in FullStatementRdfBuilderTest, the extra comma pushes the
line length over the hard limit (140 → 141 characters), so split the
array across multiple lines to keep it below the limit. The same thing
happens in one line in RdfBuilderTest, so split the DatabaseEntitySource
constructor call across multiple lines.

Bug: T325532
Change-Id: I184b019ba7ab8b435cd0774cac04011dac4585bd

Author: lucaswerkmeister

src/Deserializers/DeserializerFactory.php

@@ -48,7 +48,7 @@ public function __construct(
 	public function newEntityDeserializer(): DispatchingDeserializer {
 		return new DispatchingDeserializer( [
 			$this->newItemDeserializer(),
-			$this->newPropertyDeserializer()
+			$this->newPropertyDeserializer(),
 		] );
 	}
 

src/Deserializers/StatementDeserializer.php

@@ -25,7 +25,7 @@ class StatementDeserializer implements DispatchableDeserializer {
 	private static $rankIds = [
 		'deprecated' => Statement::RANK_DEPRECATED,
 		'normal' => Statement::RANK_NORMAL,
-		'preferred' => Statement::RANK_PREFERRED
+		'preferred' => Statement::RANK_PREFERRED,
 	];
 
 	/**

src/Serializers/AliasGroupSerializer.php

@@ -46,7 +46,7 @@ private function getSerialized( AliasGroup $aliasGroup ) {
 		foreach ( $aliasGroup->getAliases() as $value ) {
 			$result = [
 				'language' => $language,
-				'value' => $value
+				'value' => $value,
 			];
 
 			if ( $aliasGroup instanceof AliasGroupFallback ) {

src/Serializers/ItemSerializer.php

@@ -96,7 +96,7 @@ public function serialize( $object ) {
 
 	private function getSerialized( Item $item ) {
 		$serialization = [
-			'type' => $item->getType()
+			'type' => $item->getType(),
 		];
 
 		$this->addIdToSerialization( $item, $serialization );

src/Serializers/ReferenceSerializer.php

@@ -61,7 +61,7 @@ private function getSerialized( Reference $reference ) {
 		return [
 			'hash' => $reference->getHash(),
 			'snaks' => $this->snaksSerializer->serialize( $reference->getSnaks() ),
-			'snaks-order' => $this->buildSnakListOrderList( $reference->getSnaks() )
+			'snaks-order' => $this->buildSnakListOrderList( $reference->getSnaks() ),
 		];
 	}
 

src/Serializers/SerializerFactory.php

@@ -108,7 +108,7 @@ private function shouldSerializeReferenceSnaksWithHash() {
 	public function newEntitySerializer() {
 		return new DispatchingSerializer( [
 			$this->newItemSerializer(),
-			$this->newPropertySerializer()
+			$this->newPropertySerializer(),
 		] );
 	}
 

src/Serializers/SiteLinkSerializer.php

@@ -50,7 +50,7 @@ private function getSerialized( SiteLink $siteLink ) {
 		return [
 			'site' => $siteLink->getSiteId(),
 			'title' => $siteLink->getPageName(),
-			'badges' => $this->serializeBadges( $siteLink->getBadges() )
+			'badges' => $this->serializeBadges( $siteLink->getBadges() ),
 		];
 	}
 

src/Serializers/StatementSerializer.php

@@ -21,7 +21,7 @@ class StatementSerializer implements DispatchableSerializer {
 	private $rankLabels = [
 		Statement::RANK_DEPRECATED => 'deprecated',
 		Statement::RANK_NORMAL => 'normal',
-		Statement::RANK_PREFERRED => 'preferred'
+		Statement::RANK_PREFERRED => 'preferred',
 	];
 
 	/**
@@ -82,7 +82,7 @@ public function serialize( $object ) {
 	private function getSerialized( Statement $statement ) {
 		$serialization = [
 			'mainsnak' => $this->mainSnakSerializer->serialize( $statement->getMainSnak() ),
-			'type' => 'statement'
+			'type' => 'statement',
 		];
 
 		$this->addQualifiersToSerialization( $statement, $serialization );

tests/integration/EntityDeserializationCompatibilityTest.php

@@ -74,7 +74,7 @@ private function getEntitySerializationsFromDir( $dir ) {
 			if ( $fileInfo->getExtension() === 'json' ) {
 				$argumentLists[] = [
 					$fileInfo->getFilename(),
-					json_decode( file_get_contents( $fileInfo->getPathname() ), true )
+					json_decode( file_get_contents( $fileInfo->getPathname() ), true ),
 				];
 			}
 		}

tests/integration/ReferenceSerializationRoundtripTest.php

@@ -40,19 +40,19 @@ public function testSnakSerializationRoundtrips( Reference $reference ) {
 	public function referenceProvider() {
 		return [
 			[
-				new Reference()
+				new Reference(),
 			],
 			[
 				new Reference( new SnakList( [
-					new PropertyNoValueSnak( 42 )
-				] ) )
+					new PropertyNoValueSnak( 42 ),
+				] ) ),
 			],
 			[
 				new Reference( new SnakList( [
 					new PropertyNoValueSnak( 42 ),
 					new PropertySomeValueSnak( 24 ),
-					new PropertyNoValueSnak( 24 )
-				] ) )
+					new PropertyNoValueSnak( 24 ),
+				] ) ),
 			],
 		];
 	}