Convert mixed to scalar type

- This will avoid some phpstan troubles when using the payment bounded context

co-authored-by: Gabriel Birke <[email protected]>

Author: Sperling-0

src/Domain/Model/BookingDataTransformers/CreditCardBookingTransformer.php

@@ -83,7 +83,7 @@ private function validateRawData( array $rawBookingData ): void {
 	}
 
 	/**
-	 * @return array<string, mixed>
+	 * @return array<string, scalar>
 	 */
 	public function getLegacyData(): array {
 		$result = [];

src/Domain/Model/Payment.php

@@ -40,7 +40,7 @@ public function getLegacyData(): LegacyPaymentData {
 	abstract protected function getPaymentName(): string;
 
 	/**
-	 * @return array<string,mixed>
+	 * @return array<string,scalar>
 	 */
 	abstract protected function getPaymentSpecificLegacyData(): array;
 
@@ -59,7 +59,7 @@ public function getInterval(): PaymentInterval {
 	}
 
 	/**
-	 * @return array<string,mixed> Array containing all relevant payment values to display in user frontends
+	 * @return array<string,scalar> Array containing all relevant payment values to display in user frontends
 	 */
 	public function getDisplayValues(): array {
 		return [

src/UseCases/GetPayment/GetPaymentUseCase.php

@@ -27,7 +27,7 @@ public function __construct(
 	/**
 	 * @param int $paymentId (not a donation ID!)
 	 *
-	 * @return array<string, mixed>
+	 * @return array<string, scalar>
 	 *
 	 */
 	public function getPaymentDataArray( int $paymentId ): array {
@@ -89,7 +89,7 @@ private function createExtendedLegacyData( LegacyPaymentData $legacyData, Iban $
 	 * @param Payment $payment
 	 * @param Iban $iban
 	 *
-	 * @return array<string,mixed>
+	 * @return array<string,scalar>
 	 */
 	private function createExtendedPaymentFieldArray( Payment $payment, Iban $iban ): array {
 		$extendedBankData = $this->bankDataGenerator->getBankDataFromIban( $iban );