Make OpenSSL version match when building via build-wolfprovider.sh and install-openssl.sh #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
force-pushed
the
wp-ossl-version-fix
branch
5 times, most recently
from
e180c9d to
1b2ab01
Compare
padelsbach
force-pushed
the
wp-ossl-version-fix
branch
2 times, most recently
from
41cef39 to
bfca9f6
Compare
scripts/utils-general.sh
Outdated
| # the wolfProvider library | ||
|
|
||
| SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||
| REPO_ROOT=${GITHUB_WORKSPACE:-$(git rev-parse --show-toplevel)} |
Contributor
There was a problem hiding this comment.
This one makes me worry a bit. If a person calling this script has any other GITHUB_WORKSPACE env set, we would use that as the repo root right. Just seems like its common enough in GH workflows a user could already have one set.
Contributor
Author
There was a problem hiding this comment.
That's the point. In GH actions, this points to the repo root. Not sure why anyone would have this set locally.
Contributor
There was a problem hiding this comment.
fair enough. If it was set locally they would probably fail the tag checks anyways, so same result. LGTM
ColtonWilley
previously approved these changes
Nov 12, 2025
Contributor
Author
|
jenkins retest please |
Contributor
|
Jenkins retest this please. |
padelsbach
force-pushed
the
wp-ossl-version-fix
branch
2 times, most recently
from
67d2630 to
d1abdb2
Compare
…d install-openssl.sh
padelsbach
force-pushed
the
wp-ossl-version-fix
branch
from
d1abdb2 to
f7605a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.