Fix misuse of TLSX_KeyShare_Find()

egorpugin · web-flow · commit f356be5d1f96 · 2025-02-01T17:37:21.000+03:00
TLSX_KeyShare_Find() returns 1 on success and condition has incorrect non-inverted logic.
diff --git a/src/tls.c b/src/tls.c
@@ -9277,7 +9277,7 @@ int TLSX_KeyShare_Parse(WOLFSSL* ssl, const byte* input, word16 length,
             }
 
             /* Check if the group was sent. */
-            if (TLSX_KeyShare_Find(ssl, group)) {
+            if (!TLSX_KeyShare_Find(ssl, group)) {
                 WOLFSSL_ERROR_VERBOSE(BAD_KEY_SHARE_DATA);
                 return BAD_KEY_SHARE_DATA;
             }

Original file line number	Diff line number	Diff line change
`@@ -9277,7 +9277,7 @@ int TLSX_KeyShare_Parse(WOLFSSL* ssl, const byte* input, word16 length,`
`9277`	`9277`	`}`
`9278`	`9278`
`9279`	`9279`	`/* Check if the group was sent. */`
`9280`		`- if (TLSX_KeyShare_Find(ssl, group)) {`
	`9280`	`+ if (!TLSX_KeyShare_Find(ssl, group)) {`
`9281`	`9281`	`WOLFSSL_ERROR_VERBOSE(BAD_KEY_SHARE_DATA);`
`9282`	`9282`	`return BAD_KEY_SHARE_DATA;`
`9283`	`9283`	`}`