Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Re-opening a closed branch using the ui/ux in a closed pull request triggers create event and kicks off release pull request automation. #31

Closed
nerrad opened this issue Sep 7, 2020 · 1 comment · Fixed by #34
Labels
type: bug Something isn't working

Comments

@nerrad
Copy link
Collaborator

nerrad commented Sep 7, 2020

See woocommerce/woocommerce-blocks#3103 for an example of when this happened.

The Release Pull Request automation needs tweaked so it differentiates (if possible) between release branches created without an accompanying pull request (that might be closed) and created (as a result of being restored from the github ui/ux). A few thoughts:

  • I'd prefer to not have to include closed pull requests in the duplicate check because the removes the ability to try over again if something went wrong with changelog generation etc.
  • Ideally it'd be nice if when the create event fires for a branch that was re-created, there's a way for the automation to know that it's recreated (vs a brand new branch kicking off the process). I'd have to experiment a bit with this to find out.
@nerrad
Copy link
Collaborator Author

nerrad commented Nov 28, 2020

I think we could differentiate between a pull request that was closed and not merged, and a pull request that was closed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant