Skip to content

Commit d1def32

Browse files
committed
possible fix for delayshell indeterminism of dns timings
Noticed a discrepancy in dns timings dns timings were off sometimes a rtt. Not entirely sure why this is, checked chrome dns queries and even in incognito chrome sometimes sends a deterministic bunch of dns queries too chromium-i18n.appspot.com and google.com, either by chromedrivier issuing the request due to url entering (prefetching google search results) or some google stuff to protect one from malware etc. anyhow, timings should not never differ across runs. i think its some request pipelining issue in replayshell passing --all-servers to dnsmasq seems to resolve this, allthough i have no idea why, which is kinda dangerous. Observe Ticket: ravinet/mahimahi#105
1 parent 14a1a31 commit d1def32

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/util/dns_server.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ using namespace std;
1616

1717
ChildProcess start_dnsmasq( const vector< string > & extra_arguments )
1818
{
19-
vector< string > args = { DNSMASQ, "--keep-in-foreground", "--no-resolv",
19+
20+
vector< string > args = { DNSMASQ, "--keep-in-foreground", "--no-resolv", "--all-servers",
21+
// "--log-facility=-", "-q", //comment this in to see dns queries in console
2022
"--no-hosts",
2123
"-C", "/dev/null" };
2224

0 commit comments

Comments
 (0)