-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade UUID #6
Comments
I can't anticipate any concerns, but it's a good question. We can always
roll back the version if we come into problems.
…On Tue, Nov 23, 2021 at 9:04 AM Douglas Gregory ***@***.***> wrote:
installing automerge yields this warning:
npm WARN deprecated ***@***.***: Please upgrade to version 7 or higher.
Older versions may use Math.random() in certain circumstances, which is
known to be problematic. See https://v8.dev/blog/math-random for details.
So it sounds like we should update our UUID version. Any concerns with
doing so?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASLT4PSUCHEW44P5HU4AITUNONO3ANCNFSM5ITS2GSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@DMGregory am following this guide. will upgrade and push to a branch stemming from replication once ready. after verifying it works ok we can merge into replication? |
Hmm. I am confused by what is expected when upgrading. I see on line 57 of demo.js const { v4: uuidv4 } = require("uuid") That we are already using the most popular variant of the package, yet the automerge install warning is referencing version 3.x. |
@DMGregory just wanted to follow up on this. is this still a concern? if so was I on the right track? |
installing automerge yields this warning:
So it sounds like we should update our UUID version. Any concerns with doing so?
The text was updated successfully, but these errors were encountered: