Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UUID #6

Open
DMGregory opened this issue Nov 23, 2021 · 4 comments
Open

Upgrade UUID #6

DMGregory opened this issue Nov 23, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@DMGregory
Copy link
Contributor

installing automerge yields this warning:

npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

So it sounds like we should update our UUID version. Any concerns with doing so?

@DMGregory DMGregory self-assigned this Nov 23, 2021
@michaelpalumbo
Copy link
Contributor

michaelpalumbo commented Nov 23, 2021 via email

@michaelpalumbo
Copy link
Contributor

@DMGregory am following this guide. will upgrade and push to a branch stemming from replication once ready. after verifying it works ok we can merge into replication?

@michaelpalumbo michaelpalumbo added the bug Something isn't working label Nov 23, 2021
@michaelpalumbo
Copy link
Contributor

Hmm. I am confused by what is expected when upgrading. I see on line 57 of demo.js

const { v4: uuidv4 } = require("uuid")

That we are already using the most popular variant of the package, yet the automerge install warning is referencing version 3.x.

@michaelpalumbo
Copy link
Contributor

@DMGregory just wanted to follow up on this. is this still a concern? if so was I on the right track?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants