Package `myfloat` must be loaded with the same option than `mythesis`

[woshilapin]

In the class mythesis, you may load some option that are directly sent to the myfloat package, like smarttab. However, if you try to load myfloat package after that and giving different options, it will fail. A temporary solution is to send the same options to both.

\documentclass[smarttab]{mythesis}
\usepackage[smarttab]{myfloat}
...

[PierreAlbertPro]

In mythesis, configuration of the package depends on

\iftoggle{my@smarttab@bool}
{
\PassOptionsToPackage{smarttab}{myfloat}
}{}

[woshilapin]

I thought about that one and I understand the problem. However, I think this is not really a bug. This is what is happening.

The class mythesis is loading the package myfloat. The class mythesisprobably needs it to generate the tabular from the title page (list of members of the jury). You can call the option smarttab (which is about making lighter tabulars) for the class mythesis and mythesis will be forwarded to the package myfloat.

Now, if we try to load the myfloat package by ourselves, it will load the package twice. Usually, it's not a problem as long as the options sent to the package are the same (the compiler will probably identify that it's the same load and not load it twice). However, if we try to load a second time with different options, then the compiler will fail, finding 2 incompatible loads of the same package.

The thing is, the class mythesis is a class. The purpose of a class is to define the template of the document but to be also a wrapper around all the packages that has to be loaded with it. myfloat is just one of them. Therefore, it doesn't make so much sense to load it another time, you already decided to have that one loaded when you used the mythesis class.

Does this make any sense?

[PierreAlbertPro]

I've modified mythesis.dtx so the default behaviour is to include the smarttab option by default; i.e. the class works if no option is provided.

[woshilapin]

In my idea, smarttab should be an option, so you can choose to have your whole mythesis loaded with or without it.