Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreVideo attributes controls always return true #261

Open
1 task done
MKlblangenois opened this issue Aug 14, 2024 · 2 comments
Open
1 task done

CoreVideo attributes controls always return true #261

MKlblangenois opened this issue Aug 14, 2024 · 2 comments
Labels
needs: reproduction This issue needs to be reproduced independently type: bug Issue that causes incorrect or unexpected behavior

Comments

@MKlblangenois
Copy link

When I add CoreVideo on Gutenberg and try to disable controls attribute, preview on Gutenberg works with no display for controls, but GraphQL return true in attributes
image
image

Plugins Version
WPGraphQL 1.28.0
WPGraphQL Content Blocks 4.0.1
WPGraphQL for ACF 2.4.1
WordPress 6.6.1
  • I can confirm that the issue appear with minimal plugin requirement (WPGraphQL and WPGraphQL Content Blocks)
@josephfusco josephfusco added needs: reproduction This issue needs to be reproduced independently type: bug Issue that causes incorrect or unexpected behavior labels Aug 14, 2024
@justlevine
Copy link
Contributor

The reproduction is the existing CoreVideoTest, where controls is true despite it not being included in the post_content.

Fixed in #284

@justlevine
Copy link
Contributor

#284 was merged via #293, so I believe this can be closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: reproduction This issue needs to be reproduced independently type: bug Issue that causes incorrect or unexpected behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants