Skip to content

fix(core): ensure executor description is not null before calling decribe #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

samchon
Copy link
Member

@samchon samchon commented Jul 17, 2025

This pull request introduces a conditional check to ensure that the describe method is only executed when the executor.describe property in the configuration is not null. This change enhances the robustness of the MicroAgentica class by preventing unnecessary or invalid calls to the describe function.

  • packages/core/src/MicroAgentica.ts: Updated the conditional in the if statement to include a check for this.props.config?.executor?.describe !== null before calling the describe function.

@samchon samchon requested a review from Copilot July 17, 2025 11:53
@samchon samchon self-assigned this Jul 17, 2025
@samchon samchon added bug Something isn't working enhancement New feature or request labels Jul 17, 2025
@samchon samchon added this to WrtnLabs Jul 17, 2025
@samchon samchon marked this pull request as ready for review July 17, 2025 11:53
@samchon samchon merged commit 9cc054d into main Jul 17, 2025
8 of 11 checks passed
@samchon samchon deleted the feat/halt-describe branch July 17, 2025 11:53
@github-project-automation github-project-automation bot moved this to Done in WrtnLabs Jul 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a null safety check to prevent calling the describe function when the executor's describe property is null. The change aims to enhance robustness by avoiding unnecessary or invalid function calls.

  • Adds a null check for this.props.config?.executor?.describe before calling the describe function
  • Maintains existing logic while preventing potential issues when the describe property is explicitly set to null

Copy link

pkg-pr-new bot commented Jul 17, 2025

Open in StackBlitz

@agentica/benchmark

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/benchmark@478

@agentica/chat

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/chat@478

agentica

npm i https://pkg.pr.new/wrtnlabs/agentica@478

@agentica/core

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/core@478

create-agentica

npm i https://pkg.pr.new/wrtnlabs/agentica/create-agentica@478

@agentica/rpc

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/rpc@478

@agentica/vector-selector

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/vector-selector@478

commit: 696a4e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant