Skip to content

Commit 5a6b4db

Browse files
Fix update query not commiting issue in RoleDAO.
1 parent c88c85a commit 5a6b4db

File tree

1 file changed

+3
-1
lines changed
  • components/role-mgt/org.wso2.carbon.identity.role.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao

1 file changed

+3
-1
lines changed

components/role-mgt/org.wso2.carbon.identity.role.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,7 @@ public void addMainRoleToSharedRoleRelationship(String mainRoleUUID, String shar
10321032

10331033
int mainRoleUMId = 0;
10341034
int sharedRoleUMId = 0;
1035-
try (Connection connection = IdentityDatabaseUtil.getUserDBConnection(false)) {
1035+
try (Connection connection = IdentityDatabaseUtil.getUserDBConnection(true)) {
10361036
try (NamedPreparedStatement stmt = new NamedPreparedStatement(connection, GET_ROLE_UM_ID_BY_UUID)) {
10371037
stmt.setString(RoleConstants.RoleTableColumns.UM_UUID, mainRoleUUID);
10381038
ResultSet resultSet = stmt.executeQuery();
@@ -1069,7 +1069,9 @@ public void addMainRoleToSharedRoleRelationship(String mainRoleUUID, String shar
10691069
preparedStatement.setInt(RoleConstants.RoleTableColumns.UM_SHARED_ROLE_TENANT_ID, sharedRoleTenantId);
10701070
preparedStatement.setInt(RoleConstants.RoleTableColumns.UM_MAIN_ROLE_TENANT_ID, mainRoleTenantId);
10711071
preparedStatement.executeUpdate();
1072+
IdentityDatabaseUtil.commitUserDBTransaction(connection);
10721073
} catch (SQLException e) {
1074+
IdentityDatabaseUtil.rollbackUserDBTransaction(connection);
10731075
String message = "Error while adding the role relationship of role: %s.";
10741076
throw new IdentityRoleManagementServerException(RoleConstants.Error.UNEXPECTED_SERVER_ERROR.getCode(),
10751077
String.format(message, sharedRoleName), e);

0 commit comments

Comments
 (0)