Skip to content

Commit e9e99e0

Browse files
committed
Add ReadableByteStreamControllerCallPullIfNeeded
1 parent 024dd5a commit e9e99e0

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

components/script/dom/readablebytestreamcontroller.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@ impl ReadableByteStreamController {
7878
reflect_dom_object(Box::new(Self::new_inherited(stream)), global)
7979
}
8080

81-
/// <https://streams.spec.whatwg.org/#readable-stream-default-controller-should-call-pull>
81+
/// <https://streams.spec.whatwg.org/#readable-byte-stream-controller-should-call-pull>
8282
fn should_call_pull(&self) -> bool {
83+
// TODO
8384
// Step 1
8485
let stream = &self.stream;
8586
// Step 2
@@ -286,7 +287,7 @@ fn set_up_readable_byte_stream_controller(
286287
Ok(())
287288
}
288289

289-
/// <https://streams.spec.whatwg.org/#readable-stream-default-controller-call-pull-if-needed>
290+
/// <https://streams.spec.whatwg.org/#readable-byte-stream-controller-call-pull-if-needed>
290291
fn readable_byte_stream_controller_call_pull_if_needed(
291292
cx: SafeJSContext,
292293
controller: DomRoot<ReadableByteStreamController>,
@@ -442,7 +443,6 @@ impl UnderlyingSourceAlgorithms {
442443
ExceptionHandling::Rethrow,
443444
)
444445
} else {
445-
// let global = controller.global();
446446
Promise::new_resolved(
447447
&GlobalScope::current().expect("No current global"),
448448
cx,

components/script/dom/readablestream.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ impl ReadableStream {
7878
pub fn Constructor(
7979
cx: SafeJSContext,
8080
global: &GlobalScope,
81-
_proto: Option<SafeHandleObject>,
81+
proto: Option<SafeHandleObject>,
8282
underlying_source: Option<*mut JSObject>,
8383
strategy: &QueuingStrategy,
8484
) -> Fallible<DomRoot<Self>> {

components/script/dom/readablestreamdefaultcontroller.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,6 @@ impl UnderlyingSourceAlgorithms {
415415
ExceptionHandling::Rethrow,
416416
)
417417
} else {
418-
// let global = controller.global();
419418
Promise::new_resolved(
420419
&GlobalScope::current().expect("No current global"),
421420
cx,

0 commit comments

Comments
 (0)